Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-free in atf-c/map.c in low memory scenarios #23

Closed
ngie-eign opened this issue Jun 10, 2016 · 1 comment
Closed

Double-free in atf-c/map.c in low memory scenarios #23

ngie-eign opened this issue Jun 10, 2016 · 1 comment

Comments

@ngie-eign
Copy link
Contributor

Per https://svnweb.freebsd.org/base?view=revision&revision=299496 :

atf map: Fix double-free in low memory error path

If atf_list_append(, X, ) fails, X is freed.  Don't free it again.

If anyone wants to walk this patch upstream, be my guest.  I literally cannot
upstream it myself due to Google's stupid CLA.

Reported by:    Coverity
CID:        979936
Sponsored by:   EMC / Isilon Storage Division
@jmmv
Copy link
Member

jmmv commented Jun 21, 2016

Thanks for forwarding this.

I took a quick look the other day and I think the fix is wrong: the internals of atf_list seem to not be properly respecting the managed=false flag. I need to look at this in more detail though.

@jmmv jmmv closed this as completed in 710d1cf Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants