Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atf-check_test.sh workarounds don't work for rebranded versions of Darwin/FreeBSD/Linux; \e should be replaced with a more standard spelling, e.g. \033 #16

Closed
ngie-eign opened this issue Sep 19, 2014 · 0 comments
Closed

atf-check_test.sh workarounds don't work for rebranded versions of Darwin/FreeBSD/Linux; \e should be replaced with a more standard spelling, e.g. \033 #16

ngie-eign opened this issue Sep 19, 2014 · 0 comments

Comments

@ngie-eign
Copy link
Contributor

The code in atf-check_test.sh implement workarounds for OSes because...

# XXX Ugly hack to workaround the lack of \e in FreeBSD. Also, \e doesn't
# seem to work as expected in Linux. Look for a nicer solution.

"\e" is not in the POSIX standard, i.e. is only implemented on NetBSD AFAICT. It would be better to use the full spelling for "\e", i.e. "\033".
@ngie-eign ngie-eign changed the title atf-check_test.sh workarounds don't work for rebranded versions of Darwin/FreeBSD/Linux atf-check_test.sh workarounds don't work for rebranded versions of Darwin/FreeBSD/Linux; \e should be replaced with a more standard spelling, e.g. \033 Sep 19, 2014
@jmmv jmmv closed this as completed in 2e5df96 Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ngie-eign