chore: fix base gas limit test and clippy (#8961)

crates/anvil/src/eth/backend/mem/storage.rs

@@ -575,6 +575,8 @@ pub struct MinedTransactionReceipt {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::needless_return)]
+
     use super::*;
     use crate::eth::backend::db::Db;
     use alloy_primitives::{hex, Address};

crates/anvil/tests/it/fork.rs

@@ -1289,8 +1289,8 @@ async fn test_base_fork_gas_limit() {
         .unwrap()
         .unwrap();
 
-    assert_eq!(api.gas_limit(), uint!(120_000_000_U256));
-    assert_eq!(block.header.gas_limit, 120_000_000_u128);
+    assert!(api.gas_limit() >= uint!(132_000_000_U256));
+    assert!(block.header.gas_limit >= 132_000_000_u128);
 }
 
 // <https://github.com/foundry-rs/foundry/issues/7023>

crates/anvil/tests/it/main.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::needless_return)]
+
 mod abi;
 mod anvil;
 mod anvil_api;

crates/cast/bin/main.rs

@@ -42,6 +42,7 @@ fn main() -> Result<()> {
     main_args(args)
 }
 
+#[allow(clippy::needless_return)]
 #[tokio::main]
 async fn main_args(args: CastArgs) -> Result<()> {
     match args.cmd {

crates/cast/src/rlp_converter.rs

@@ -47,7 +47,7 @@ impl Decodable for Item {
 
 impl Item {
     pub(crate) fn value_to_item(value: &Value) -> eyre::Result<Self> {
-        return match value {
+        match value {
             Value::Null => Ok(Self::Data(vec![])),
             Value::Bool(_) => {
                 eyre::bail!("RLP input can not contain booleans")

crates/cheatcodes/src/test/expect.rs

@@ -597,7 +597,7 @@ pub(crate) fn handle_expect_emit(
     let Some(expected) = &event_to_fill_or_check.log else {
         // Unless the caller is trying to match an anonymous event, the first topic must be
         // filled.
-        if event_to_fill_or_check.anonymous || log.topics().first().is_some() {
+        if event_to_fill_or_check.anonymous || !log.topics().is_empty() {
             event_to_fill_or_check.log = Some(log.data.clone());
             // If we only filled the expected log then we put it back at the same position.
             state.expected_emits.insert(index_to_fill_or_check, event_to_fill_or_check);

crates/chisel/bin/main.rs

@@ -102,6 +102,7 @@ fn main() -> eyre::Result<()> {
     main_args(args)
 }
 
+#[allow(clippy::needless_return)]
 #[tokio::main]
 async fn main_args(args: Chisel) -> eyre::Result<()> {
     // Keeps track of whether or not an interrupt was the last input

crates/common/src/selectors.rs

@@ -581,6 +581,8 @@ pub fn parse_signatures(tokens: Vec<String>) -> ParsedSignatures {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::needless_return)]
+
     use super::*;
 
     #[tokio::test(flavor = "multi_thread")]

crates/evm/core/src/backend/mod.rs

@@ -1979,6 +1979,8 @@ fn apply_state_changeset(
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::needless_return)]
+
     use crate::{backend::Backend, fork::CreateFork, opts::EvmOpts};
     use alloy_primitives::{Address, U256};
     use alloy_provider::Provider;

crates/evm/core/src/fork/database.rs

@@ -263,6 +263,8 @@ impl DatabaseRef for ForkDbSnapshot {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::needless_return)]
+
     use super::*;
     use crate::backend::BlockchainDbMeta;
     use foundry_common::provider::get_http_provider;

crates/evm/traces/src/identifier/signatures.rs

@@ -162,6 +162,8 @@ impl Drop for SignaturesIdentifier {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::needless_return)]
+
     use super::*;
 
     #[tokio::test(flavor = "multi_thread")]

crates/forge/bin/cmd/clone.rs

@@ -609,6 +609,8 @@ impl EtherscanClient for Client {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::needless_return)]
+
     use super::*;
     use alloy_primitives::hex;
     use foundry_compilers::Artifact;

crates/forge/bin/cmd/doc/server.rs

@@ -90,6 +90,7 @@ impl Server {
     }
 }
 
+#[allow(clippy::needless_return)]
 #[tokio::main]
 async fn serve(build_dir: PathBuf, address: SocketAddr, file_404: &str) -> io::Result<()> {
     let file_404 = build_dir.join(file_404);

crates/forge/tests/it/main.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::needless_return)]
+
 pub mod config;
 pub mod test_helpers;
 

crates/script/src/sequence.rs

@@ -374,8 +374,7 @@ impl ScriptSequence {
 
 /// Converts the `sig` argument into the corresponding file path.
 ///
-/// This accepts either the signature of the function or the raw calldata
-
+/// This accepts either the signature of the function or the raw calldata.
 pub fn sig_to_file_name(sig: &str) -> String {
     if let Some((name, _)) = sig.split_once('(') {
         // strip until call argument parenthesis

crates/test-utils/src/rpc.rs

@@ -178,6 +178,8 @@ fn next_url(is_ws: bool, chain: NamedChain) -> String {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::needless_return)]
+
     use super::*;
     use alloy_primitives::address;
     use foundry_config::Chain;

crates/verify/src/etherscan/mod.rs

@@ -452,6 +452,8 @@ async fn ensure_solc_build_metadata(version: Version) -> Result<Version> {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::needless_return)]
+
     use super::*;
     use clap::Parser;
     use foundry_common::fs;

crates/wallets/src/wallet.rs

@@ -149,6 +149,8 @@ impl From<RawWalletOpts> for WalletOpts {
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::needless_return)]
+
     use alloy_signer::Signer;
     use std::{path::Path, str::FromStr};