perf: use improved iso-git multiple-add API

Author: mshanemc

src/shared/localShadowRepo.ts

@@ -9,17 +9,9 @@
 import * as path from 'path';
 import * as os from 'os';
 import * as fs from 'fs';
-import { PerformanceObserver, performance } from 'perf_hooks';
 import { NamedPackageDir, Logger } from '@salesforce/core';
 import * as git from 'isomorphic-git';
 import { pathIsInFolder } from './functions';
-const obs = new PerformanceObserver((items) => {
-  const item = items.getEntries()[0];
-  console.log(`${item.name} : ${item.duration}`);
-  performance.clearMarks(item.name);
-});
-
-obs.observe({ type: 'measure' });
 
 const cache = {};
 const gitIgnoreFileName = '.gitignore';
@@ -74,14 +66,11 @@ export class ShadowRepo {
 
   // think of singleton behavior but unique to the projectPath
   public static async getInstance(options: ShadowRepoOptions): Promise<ShadowRepo> {
-    performance.mark('start-instance');
     if (!ShadowRepo.instanceMap.has(options.projectPath)) {
       const newInstance = new ShadowRepo(options);
       await newInstance.init();
       ShadowRepo.instanceMap.set(options.projectPath, newInstance);
     }
-    performance.mark('end-instance');
-    performance.measure('getInstance', 'start-instance', 'end-instance');
     return ShadowRepo.instanceMap.get(options.projectPath) as ShadowRepo;
   }
 
@@ -128,7 +117,6 @@ export class ShadowRepo {
    * @returns StatusRow[]
    */
   public async getStatus(noCache = false): Promise<StatusRow[]> {
-    performance.mark('start-status');
     if (!this.status || noCache) {
       try {
         // only ask about OS once but use twice
@@ -163,8 +151,6 @@ export class ShadowRepo {
         await this.unStashIgnoreFile();
       }
     }
-    performance.mark('end-status');
-    performance.measure('getStatus', 'start-status', 'end-status');
     return this.status;
   }
 
@@ -251,20 +237,13 @@ export class ShadowRepo {
       deletedFiles = deletedFiles.map((filepath) => path.normalize(filepath).split(path.sep).join(path.posix.sep));
     }
     try {
-      performance.mark('start-add');
-      // for (const filepath of [...new Set(deployedFiles)]) {
-      // performance.mark(`item-add-${filepath}`);
-      await git.add({ fs, dir: this.projectPath, gitdir: this.gitDir, filepath: [...new Set(deployedFiles)], cache });
-      // performance.mark(`item-end-${filepath}`);
-      // performance.measure(`add-${filepath}`, `item-add-${filepath}`, `item-end-${filepath}`);
-      // }
-      performance.mark('end-add');
-      performance.measure('git add', 'start-add', 'end-add');
+      if (deployedFiles.length) {
+        await git.add({ fs, dir: this.projectPath, gitdir: this.gitDir, filepath: [...new Set(deployedFiles)], cache });
+      }
 
       for (const filepath of [...new Set(deletedFiles)]) {
         await git.remove({ fs, dir: this.projectPath, gitdir: this.gitDir, filepath, cache });
       }
-      performance.mark('start-commit');
 
       const sha = await git.commit({
         fs,
@@ -274,8 +253,6 @@ export class ShadowRepo {
         author: { name: 'sfdx source tracking' },
         cache,
       });
-      performance.mark('end-commit');
-      performance.measure('git commit', 'start-commit', 'end-commit');
       // status changed as a result of the commit.  This prevents users from having to run getStatus(true) to avoid cache
       if (needsUpdatedStatus) {
         await this.getStatus(true);
@@ -320,6 +297,4 @@ export class ShadowRepo {
       )
     );
   }
-
-  // private async addMultipleFiles(files: string[]): Promise<void> {}
 }