feat: create on asyncOptionalCreatable requires that P extend object

* chore: updates from devScripts

* chore: linter updates

* feat: create on asyncOptionalCreatable requires that P extend object

* refactor: the tests say object is better

Co-authored-by: mshanemc <shane.mclaughlin@salesforce.com>

Author: SF-CLI-BOT

package.json

@@ -35,30 +35,29 @@
     "tslib": "^2.2.0"
   },
   "devDependencies": {
-    "@salesforce/dev-config": "^2.1.3",
-    "@salesforce/dev-scripts": "^1.0.0",
+    "@salesforce/dev-config": "^3.0.0",
+    "@salesforce/dev-scripts": "^3.1.0",
     "@salesforce/prettier-config": "^0.0.2",
-    "@typescript-eslint/eslint-plugin": "^4.2.0",
-    "@typescript-eslint/parser": "^4.2.0",
+    "@typescript-eslint/eslint-plugin": "^5.33.0",
+    "@typescript-eslint/parser": "^5.33.0",
     "chai": "^4.2.0",
-    "eslint": "^7.27.0",
-    "eslint-config-prettier": "^6.11.0",
-    "eslint-config-salesforce": "^0.1.6",
+    "eslint": "^8.21.0",
+    "eslint-config-prettier": "^8.5.0",
+    "eslint-config-salesforce": "^1.1.0",
     "eslint-config-salesforce-license": "^0.1.6",
-    "eslint-config-salesforce-typescript": "^0.2.7",
+    "eslint-config-salesforce-typescript": "^1.1.1",
     "eslint-plugin-header": "^3.0.0",
     "eslint-plugin-import": "2.26.0",
-    "eslint-plugin-jsdoc": "^35.1.2",
+    "eslint-plugin-jsdoc": "^39.3.6",
     "eslint-plugin-prefer-arrow": "^1.2.1",
-    "eslint-plugin-prettier": "^3.1.3",
     "husky": "^7.0.4",
     "lodash-cli": "^4.17.5",
-    "mocha": "^8.4.0",
+    "mocha": "^9.1.3",
     "nyc": "^15.1.0",
-    "prettier": "^2.0.5",
+    "prettier": "^2.7.1",
     "pretty-quick": "^3.1.0",
     "sinon": "10.0.0",
     "ts-node": "^10.0.0",
     "typescript": "^4.8.4"
   }
-}
+}

src/creatable.ts

@@ -57,7 +57,7 @@ export abstract class AsyncOptionalCreatable<O = object> {
    *
    * @param options An options object providing initialization params to the async constructor.
    */
-  public static async create<P, T extends AsyncOptionalCreatable<P>>(
+  public static async create<P extends object, T extends AsyncOptionalCreatable<P>>(
     this: new (opts?: P) => T,
     options?: P
   ): Promise<T> {

src/env.ts

@@ -14,7 +14,7 @@ import { toNumber, toBoolean } from './nodash';
  * for accessing environment variables of different anticipated shapes.
  */
 export class Env {
-  public constructor(private store: Dictionary<string> = (process && process.env) || {}) {
+  public constructor(private store: Dictionary<string> = process?.env || {}) {
     this.store = store;
   }
 
@@ -33,7 +33,7 @@ export class Env {
   public getString(key: string, def: string): string;
   // underlying method
   public getString(key: string, def?: string): Optional<string> {
-    return this.store[key] || def;
+    return this.store[key] ?? def;
   }
 
   /**

src/errors.ts

@@ -33,7 +33,7 @@ export class NamedError extends Error {
 
   public get fullStack(): string | undefined {
     let stack = this.stack;
-    const causedStack = this.cause?.fullStack || this.cause?.stack;
+    const causedStack = this.cause?.fullStack ?? this.cause?.stack;
     if (causedStack) {
       stack = `${stack ? stack + '\n' : ''}Caused by: ${causedStack}`;
     }
@@ -82,7 +82,7 @@ export class JsonParseError extends NamedError {
 
   private static format(cause: Error, path?: string, line?: number, errorPortion?: string): string {
     if (line == null) return cause.message || 'Unknown cause';
-    return `Parse error in file ${path || 'unknown'} on line ${line}\n${errorPortion || cause.message}`;
+    return `Parse error in file ${path ?? 'unknown'} on line ${line}\n${errorPortion ?? cause.message}`;
   }
 }
 

src/nodash/internal.ts

@@ -60,14 +60,11 @@ export function snakeCase(str: string): string;
 export function snakeCase(str?: string): Optional<string>;
 // underlying function
 export function snakeCase(str?: string): Optional<string> {
-  return (
-    str &&
-    str
-      .replace(/([a-z])([A-Z])/g, '$1_$2')
-      .toLowerCase()
-      .replace(/\W/g, '_')
-      .replace(/^_+|_+$/g, '')
-  );
+  return str
+    ?.replace(/([a-z])([A-Z])/g, '$1_$2')
+    .toLowerCase()
+    .replace(/\W/g, '_')
+    .replace(/^_+|_+$/g, '');
 }
 
 /**

test/creatable.test.ts

@@ -65,6 +65,7 @@ class OptionalConfig extends AsyncOptionalCreatable<OptionalConfig.Options> {
     return this.options ? this.options.bazEnabled : false;
   }
 
+  // eslint-disable-next-line class-methods-use-this
   protected async init(): Promise<void> {
     // Imagine cool async stuff here
   }
@@ -81,6 +82,7 @@ class NoOptionsConfig extends AsyncOptionalCreatable {
     super();
   }
 
+  // eslint-disable-next-line class-methods-use-this
   protected async init(): Promise<void> {
     // Imagine cool async stuff here
   }