fix: throttle promise all infinite loop

@W-13829750@ remove generator in favor of shifting entries from queue

Author: peternhale

src/throttledPromiseAll.ts

@@ -133,22 +133,14 @@ export class ThrottledPromiseAll<T, O = T> {
   }
 
   private async dequeue(): Promise<void> {
-    const generator = function* (
-      data: Array<PromiseItem<T, O | undefined>>
-    ): Generator<PromiseItem<T, O | undefined> | undefined> {
-      while (data.length > 0) {
-        yield data.shift();
-      }
-    };
     const concurrencyPool: Map<number, Promise<IndexedResult<O> | undefined>> = new Map<
       number,
       Promise<IndexedResult<O> | undefined>
     >();
-    const get = generator(this.queue);
     let index = 0;
     while (this.queue.length > 0 || concurrencyPool.size > 0) {
       while (concurrencyPool.size < this.concurrency) {
-        const item = get.next().value as PromiseItem<T, O | undefined>;
+        const item = this.queue.shift();
         if (!item) {
           break;
         }

test/promiseQueue.test.ts

@@ -5,8 +5,7 @@
  * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
  */
 import { expect } from 'chai';
-import { ThrottledPromiseAll } from '../src';
-import { Duration } from '../src';
+import { Duration, ThrottledPromiseAll } from '../src';
 
 describe('throttledPromiseAll', () => {
   const numberProducer = (
@@ -80,10 +79,17 @@ describe('throttledPromiseAll', () => {
     throttledPromiseAll.add(
       1,
       (source: number, throttledPromise: ThrottledPromiseAll<number, number | undefined>): Promise<number> => {
+        // add more to the queue after a couple of seconds
         if (source === 1) {
-          throttledPromise.add([2, 3, 4, 5], numberProducer);
+          return new Promise((resolve) => {
+            setTimeout(() => {
+              throttledPromise.add([2, 3, 4, 5], numberProducer);
+              resolve(source + 1);
+            }, 2000);
+          });
+        } else {
+          return Promise.resolve(source + 1);
         }
-        return Promise.resolve(source + 1);
       }
     );
     await throttledPromiseAll.all();