Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCode viewer options non-functional #35

Closed
splitbrain opened this issue Feb 4, 2013 · 6 comments
Closed

GCode viewer options non-functional #35

splitbrain opened this issue Feb 4, 2013 · 6 comments

Comments

@splitbrain
Copy link
Contributor

The new GCode viewer is absolutely awesome! However, the options below the viewer seem to do nothing for me. I assume they should unfold some settings?

I don't get any JS errors though. Tested on Chromium 24
@Lenbok
Copy link

Lenbok commented Feb 5, 2013

I assume they are hangovers from when the gcode viewer was a standalone app.

The non-working options should be removed/hidden.

@hudbrog
Copy link
Contributor

hudbrog commented Feb 13, 2013

Actually, these should work.. and for me they do work.. well, most of the time. I'll take a look later to see where the problem is.

@lthomas987
Copy link

I have observed this as well. Tonight I discovered that the gcode viewer options work under Chrome Version 25.0.1364.160 but not under Firefox 19.0.2. These are both the current version on OSX right now. I haven't checked Safari and can't right now as I am staring at the Server is offline dialog waiting for my bed to heat up.

foosel added a commit that referenced this issue Mar 10, 2013
@foosel
Temporary workaround for the gcode viewer options not cooperating unt…
1ebc0c0 
…il those are integrated a bit more.

Targets #35.
@foosel
Copy link
Member

foosel commented Mar 10, 2013

@lthomas987 Do you always get the offline dialog during heatup? That shouldn't happen actually... If so could you open another ticket for this, maybe with some additional info re printer model, communication log etc?

Regarding the controls not working, I'm trying to figure out a way to move most of these into the settings actually. I've now simply expanded them all for the time being, until I manage to do so. I hope this works, I've yet to successfully reproduce the issue when I try to hunt it down.

@daprice daprice mentioned this issue Mar 25, 2013
Closed
@imitation
Copy link
Contributor

If you manage to switch to the gcoder viewer's tab fast enough after a refresh and open some of the sections, they keep working for a while.
FF19

foosel added a commit that referenced this issue Jan 5, 2014
@foosel
More work on the GCode viewer
ad556e7 
- confirmation dialog when trying to visualize large files (different threshold for mobile and "regular" devices, configurable of course, although only via config file right now) - should also help a bit with issues leading to #215
 - proper clearing of the viewer area when reconnecting to the backend (e.g. after server restart)

 Also all of this plus previous commits closes #35
@foosel
Copy link
Member

foosel commented Jan 5, 2014

Closed in devel (because the options where completely changed there...)

@foosel foosel closed this as completed Jan 5, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@foosel @splitbrain @Lenbok @hudbrog @imitation @lthomas987