fix: handle vim.notify nil messages for nvim-notify. Fixes #109

Author: folke

lua/noice/message/manager.lua

@@ -19,7 +19,7 @@ end
 
 ---@param message NoiceMessage
 function M.add(message)
-  if not message:is_empty() then
+  if not (message:is_empty() and vim.tbl_isempty(message.opts)) then
     message.tick = next_tick()
     message.mtime = vim.fn.localtime()
     M._history[message.id] = message
@@ -80,6 +80,10 @@ function M.sort(messages, reverse)
   )
 end
 
+function M.get_by_id(id)
+  return M._history[id]
+end
+
 ---@class NoiceMessageOpts
 ---@field history? boolean
 ---@field sort? boolean

lua/noice/source/notify.lua

@@ -55,6 +55,12 @@ function M.notify(msg, level, opts)
   message.opts = opts or {}
   message.level = level
   message.once = true
+
+  if msg == nil then
+    -- special case for some destinations like nvim-notify
+    message.opts.is_nil = true
+  end
+
   Msg.check_clear()
   Manager.add(message)
   if Util.is_blocking() then

lua/noice/view/backend/notify.lua

@@ -2,6 +2,7 @@ local require = require("noice.util.lazy")
 
 local Util = require("noice.util")
 local View = require("noice.view")
+local Manager = require("noice.message.manager")
 
 ---@class NoiceNotifyOptions
 ---@field title string
@@ -16,7 +17,7 @@ local defaults = {
 }
 
 ---@class NotifyInstance
----@field notify fun(msg:string, level?:string|number, opts?:table): notify.Record}
+---@field notify fun(msg:string?, level?:string|number, opts?:table): notify.Record}
 
 ---@alias notify.RenderFun fun(buf:buffer, notif: Notification, hl: NotifyBufHighlights, config: notify.Config)
 
@@ -25,7 +26,6 @@ local defaults = {
 ---@field buf? number
 ---@field notif table<NotifyInstance, notify.Record>
 ---@field super NoiceView
----@field _notifs table<number, any>
 ---@diagnostic disable-next-line: undefined-field
 local NotifyView = View:extend("NotifyView")
 
@@ -52,7 +52,6 @@ end
 function NotifyView:init(opts)
   NotifyView.super.init(self, opts)
   self.notif = {}
-  self._notifs = {}
 end
 
 function NotifyView:is_available()
@@ -129,7 +128,7 @@ function NotifyView:_notify(msg)
     on_close = function()
       self.notif[instance] = nil
       for _, m in ipairs(msg.messages) do
-        self._notifs[m.id] = nil
+        m.opts.notify_id = nil
       end
       self.win = nil
     end,
@@ -139,14 +138,22 @@ function NotifyView:_notify(msg)
   if msg.opts then
     opts = vim.tbl_deep_extend("force", opts, msg.opts)
     if type(msg.opts.replace) == "table" then
-      opts.replace = self._notifs[msg.opts.replace.id]
+      local m = Manager.get_by_id(msg.opts.replace.id)
+      opts.replace = m and m.opts.notify_id or nil
     end
   end
 
-  local id = instance.notify(msg.content, level, opts)
+  ---@type string?
+  local content = msg.content
+
+  if msg.opts and msg.opts.is_nil then
+    content = nil
+  end
+
+  local id = instance.notify(content, level, opts)
   self.notif[instance] = id
   for _, m in ipairs(msg.messages) do
-    self._notifs[m.id] = id
+    m.opts.notify_id = id
   end
 end