fix: use vim.F.unpack_len and vim.F.pack_len. Fixes a number of issues...

Author: folke

lua/noice/source/lsp/progress.lua

@@ -88,9 +88,9 @@ function M.setup()
   })
   local orig = vim.lsp.handlers["$/progress"]
   vim.lsp.handlers["$/progress"] = function(...)
-    local args = { ... }
+    local args = vim.F.pack_len(...)
     Util.try(function()
-      M.progress(unpack(args))
+      M.progress(vim.F.unpack_len(args))
     end)
     orig(...)
   end

lua/noice/source/lsp/signature.lua

@@ -87,17 +87,14 @@ function M.check(buf, chars, encoding)
 
     if vim.tbl_contains(chars, M.get_char(buf)) then
       local params = vim.lsp.util.make_position_params(0, encoding)
-      vim.lsp.buf_request(
-        buf,
-        "textDocument/signatureHelp",
-        params,
-        vim.lsp.with(require("noice.source.lsp").signature, {
+      vim.lsp.buf_request(buf, "textDocument/signatureHelp", params, function(err, result, ctx)
+        require("noice.source.lsp").signature(err, result, ctx, {
           trigger = true,
           stay = function()
             return vim.tbl_contains(chars, M.get_char(buf))
           end,
         })
-      )
+      end)
     end
   end)
 end

lua/noice/util/call.lua

@@ -128,11 +128,11 @@ function M:notify(err)
 end
 
 function M:__call(...)
-  local args = { ... }
+  local args = vim.F.pack_len(...)
 
   -- wrap the function and call with args
   local wrapped = function()
-    return self._fn(unpack(args))
+    return self._fn(vim.F.unpack_len(args))
   end
 
   -- error handler
@@ -154,7 +154,7 @@ function M:__call(...)
 
   if not ok and self._defer_retry then
     vim.defer_fn(function()
-      self(unpack(args))
+      self(vim.F.unpack_len(args))
     end, 100)
   end
 

lua/noice/util/hacks.lua

@@ -142,9 +142,8 @@ M.before_input = false
 function M.fix_input()
   local function wrap(fn, skip)
     return function(...)
-      local args = { ... }
-      if skip and skip(unpack(args)) then
-        return fn(unpack(args))
+      if skip and skip(...) then
+        return fn(...)
       end
 
       local Manager = require("noice.message.manager")
@@ -155,7 +154,7 @@ function M.fix_input()
 
       M.hide_cursor()
       ---@type boolean, any
-      local ok, ret = pcall(fn, unpack(args))
+      local ok, ret = pcall(fn, ...)
       M.show_cursor()
 
       -- clear any message right after input

lua/noice/util/init.lua

@@ -65,10 +65,10 @@ end
 function M.debounce(ms, fn)
   local timer = vim.loop.new_timer()
   return function(...)
-    local argv = { ... }
+    local argv = vim.F.pack_len(...)
     timer:start(ms, 0, function()
       timer:stop()
-      vim.schedule_wrap(fn)(unpack(argv))
+      vim.schedule_wrap(fn)(vim.F.unpack_len(argv))
     end)
   end
 end
@@ -84,11 +84,11 @@ function M.interval(ms, fn, opts)
   local timer = vim.loop.new_timer()
   local running = false
   return function(...)
-    local args = { ... }
+    local args = vim.F.pack_len(...)
     if not running then
       running = true
       timer:start(ms, ms, function()
-        fn(unpack(args))
+        fn(vim.F.unpack_len(args))
         if not (opts.enabled and opts.enabled()) then
           timer:stop()
           running = false