Resolved warning C4127: conditional expression is constant (#3923)

matt77hias · web-flow · commit 550437b29ecc · 2024-04-07T11:01:26.000-07:00
diff --git a/include/fmt/base.h b/include/fmt/base.h
@@ -2812,7 +2812,7 @@ template <typename T, typename Char, type TYPE> struct native_formatter {
   FMT_CONSTEXPR auto parse(ParseContext& ctx) -> const Char* {
     if (ctx.begin() == ctx.end() || *ctx.begin() == '}') return ctx.begin();
     auto end = parse_format_specs(ctx.begin(), ctx.end(), specs_, ctx, TYPE);
-    if (TYPE == type::char_type) check_char_specs(specs_);
+    if (const_check(TYPE == type::char_type)) check_char_specs(specs_);
     return end;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -2812,7 +2812,7 @@ template <typename T, typename Char, type TYPE> struct native_formatter {`
`2812`	`2812`	`FMT_CONSTEXPR auto parse(ParseContext& ctx) -> const Char* {`
`2813`	`2813`	`if (ctx.begin() == ctx.end() \|\| *ctx.begin() == '}') return ctx.begin();`
`2814`	`2814`	`auto end = parse_format_specs(ctx.begin(), ctx.end(), specs_, ctx, TYPE);`
`2815`		`- if (TYPE == type::char_type) check_char_specs(specs_);`
	`2815`	`+ if (const_check(TYPE == type::char_type)) check_char_specs(specs_);`
`2816`	`2816`	`return end;`
`2817`	`2817`	`}`
`2818`	`2818`