main: remove redundant else

hiddeco · hiddeco · commit a2463723ece3 · 2021-11-23T09:16:27.000+01:00
Signed-off-by: Hidde Beydals &lt;hello@hidde.co&gt;
diff --git a/main.go b/main.go
@@ -125,11 +125,10 @@ func main() {
 
 	var eventRecorder *events.Recorder
 	if eventsAddr != "" {
-		if er, err := events.NewRecorder(eventsAddr, controllerName); err != nil {
+		var err error
+		if eventRecorder, err = events.NewRecorder(eventsAddr, controllerName); err != nil {
 			setupLog.Error(err, "unable to create event recorder")
 			os.Exit(1)
-		} else {
-			eventRecorder = er
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -125,11 +125,10 @@ func main() {`
`125`	`125`
`126`	`126`	`var eventRecorder *events.Recorder`
`127`	`127`	`if eventsAddr != "" {`
`128`		`- if er, err := events.NewRecorder(eventsAddr, controllerName); err != nil {`
	`128`	`+ var err error`
	`129`	`+ if eventRecorder, err = events.NewRecorder(eventsAddr, controllerName); err != nil {`
`129`	`130`	`setupLog.Error(err, "unable to create event recorder")`
`130`	`131`	`os.Exit(1)`
`131`		`- } else {`
`132`		`- eventRecorder = er`
`133`	`132`	`}`
`134`	`133`	`}`
`135`	`134`