Remove minio region

Twice recently the minio region seemed to have changed
unsetting it seems to work consistently.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>

Author: Paulo Gomes

pkg/minio/minio_test.go

@@ -39,13 +39,13 @@ import (
 const (
 	objectName string = "test.yaml"
 	objectEtag string = "2020beab5f1711919157756379622d1d"
-	region     string = "us-west-2"
 )
 
 var (
-	minioClient *MinioClient
-	bucketName  = "test-bucket-minio" + uuid.New().String()
-	secret      = corev1.Secret{
+	firstFailure = true
+	minioClient  *MinioClient
+	bucketName   = "test-bucket-minio" + uuid.New().String()
+	secret       = corev1.Secret{
 		ObjectMeta: v1.ObjectMeta{
 			Name:      "minio-secret",
 			Namespace: "default",
@@ -72,7 +72,6 @@ var (
 		Spec: sourcev1.BucketSpec{
 			BucketName: bucketName,
 			Endpoint:   "play.min.io",
-			Region:     region,
 			Provider:   "generic",
 			Insecure:   true,
 			SecretRef: &meta.LocalObjectReference{
@@ -88,7 +87,6 @@ var (
 		Spec: sourcev1.BucketSpec{
 			BucketName: bucketName,
 			Endpoint:   "play.min.io",
-			Region:     region,
 			Provider:   "aws",
 			Insecure:   true,
 		},
@@ -226,11 +224,14 @@ func TestValidateSecret(t *testing.T) {
 }
 
 func createBucket(ctx context.Context) {
-	if err := minioClient.Client.MakeBucket(ctx, bucketName, miniov7.MakeBucketOptions{Region: region}); err != nil {
+	if err := minioClient.Client.MakeBucket(ctx, bucketName, miniov7.MakeBucketOptions{}); err != nil {
 		exists, errBucketExists := minioClient.BucketExists(ctx, bucketName)
 		if errBucketExists == nil && exists {
 			deleteBucket(ctx)
-		} else {
+			return
+		} else if firstFailure {
+			firstFailure = false
+
 			log.Fatalln(err)
 		}
 	}