Skip to content

Commit 1266bea

Browse files
author
Paulo Gomes
committed
libgit2: remove connection caching
Connection caching was a feature created to resolve upstream issues raised from concurrent ssh connections. Some scenarios were based on multiple key exchange operations happening at the same time. This PR removes the connection caching, and instead: - Services Session.StdoutPipe() as soon as possible, as it is a known source of blocking SSH connections. - Reuse SSH connection within the same subtransport, eliminating the need for new handshakes when talking with the same server. - Simplifies the entire transport logic for better maintainability. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
1 parent 9c1bbc4 commit 1266bea

File tree

3 files changed

+64
-328
lines changed

3 files changed

+64
-328
lines changed

go.mod

+2-1
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ replace github.com/opencontainers/image-spec => github.com/opencontainers/image-
7272
// Fix CVE-2021-43816
7373
replace github.com/containerd/containerd => github.com/containerd/containerd v1.6.1
7474

75+
require golang.org/x/net v0.0.0-20220425223048-2871e0cb64e4
76+
7577
require (
7678
cloud.google.com/go v0.100.2 // indirect
7779
cloud.google.com/go/compute v1.6.0 // indirect
@@ -200,7 +202,6 @@ require (
200202
go.uber.org/atomic v1.7.0 // indirect
201203
go.uber.org/multierr v1.6.0 // indirect
202204
go.uber.org/zap v1.21.0 // indirect
203-
golang.org/x/net v0.0.0-20220425223048-2871e0cb64e4 // indirect
204205
golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5 // indirect
205206
golang.org/x/sys v0.0.0-20220503163025-988cb79eb6c6 // indirect
206207
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 // indirect

0 commit comments

Comments
 (0)