Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anchoring stopped working #369

Closed
davidkarlsen opened this issue Jun 16, 2021 · 2 comments
Closed

anchoring stopped working #369

davidkarlsen opened this issue Jun 16, 2021 · 2 comments

Comments

@davidkarlsen
Copy link
Contributor

davidkarlsen commented Jun 16, 2021

I had to:

 apiVersion: sources.knative.dev/v1beta1
 kind: ContainerSource
 metadata:
-  name: &srcname awssqs-source
+  name: awssqs-source
   namespace: devops
 spec:
   template:
@@ -24,7 +24,7 @@ spec:
 
         # Knative system variables
         - name: NAME
-          value: *srcname
+          value: awssqs-source
         - name: NAMESPACE
           valueFrom:
             fieldRef:

when upgrading from v0.14.2 to v0.15.0, ie upgrading kustomize-controller:

-        image: ghcr.io/fluxcd/kustomize-controller:v0.12.2
+        image: ghcr.io/fluxcd/kustomize-controller:v0.13.0
@hiddeco
Copy link
Member

hiddeco commented Jun 16, 2021

See: #367

@hiddeco hiddeco closed this as completed Jun 16, 2021
@sa-spag
Copy link

sa-spag commented Sep 3, 2021

There's a workaround that was suggested on kubernetes-sigs/kustomize#3675 (comment). It basically introduces a plugin that resolves anchors and aliases beforehand using yq. Since plugins are not supported yet (#120), it's not trivially possible to deploy the workaround. Depending on how likely it is for the upstream issue to be fixed in the near future, could we consider embedding such plugin in the kustomize-controller controller?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants