Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pruning for remote clusters #127

Closed
stefanprodan opened this issue Sep 30, 2020 · 1 comment · Fixed by #135
Closed

Enable pruning for remote clusters #127

stefanprodan opened this issue Sep 30, 2020 · 1 comment · Fixed by #135
Assignees
@stealthybox
Labels
enhancement New feature or request

Comments

@stefanprodan
Copy link
Member

When targeting a remote cluster with spec.kubeConfig, the pruning is skipped. To implemented garbage collection we need to initialise the controller-runtime client using the kube config file.
@stefanprodan stefanprodan added the enhancement New feature or request label Sep 30, 2020
@stealthybox
Copy link
Member

I'll take this after cleaning up the impersonation bits.
It's a similar code-path to the client bootstrap in helm-controller.

@stealthybox stealthybox mentioned this issue Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stealthybox stealthybox

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@stealthybox @stefanprodan