PR-676 update code based on review

Signed-off-by: longquan0104 <longquan0104@gmail.com>

Author: longquan0104

Makefile

@@ -85,8 +85,8 @@ api-docs: gen-crd-api-reference-docs
 
 # Run go mod tidy
 tidy:
-	cd api; rm -f go.sum; go mod tidy -compat=1.19
-	rm -f go.sum; go mod tidy -compat=1.19
+	cd api; rm -f go.sum; go mod tidy -compat=1.20
+	rm -f go.sum; go mod tidy -compat=1.20
 
 # Run go fmt against code
 fmt:

internal/util/util.go

@@ -30,10 +30,7 @@ import (
 // given chartutil.Values.
 func ValuesChecksum(values map[string]interface{}) string {
 	newValues := copyValues(values)
-	var (
-		s   []byte
-		err error
-	)
+	var s []byte
 
 	if len(newValues) != 0 {
 		// cleanUpInterfaceMap
@@ -44,10 +41,7 @@ func ValuesChecksum(values map[string]interface{}) string {
 		// Sort
 		SortMapSlice(msValues)
 		// Marshal
-		s, err = goyaml.Marshal(msValues)
-		if err != nil {
-			panic(err)
-		}
+		s, _ = goyaml.Marshal(msValues)
 	}
 	// Gethash
 	return fmt.Sprintf("%x", sha1.Sum(s))
@@ -76,10 +70,8 @@ func cleanUpMapValue(v interface{}) interface{} {
 		return cleanUpInterfaceArray(v)
 	case map[interface{}]interface{}:
 		return cleanUpInterfaceMap(v)
-	case string:
-		return v
 	default:
-		return fmt.Sprintf("%v", v)
+		return v
 	}
 }
 
@@ -101,10 +93,7 @@ func cleanUpInterfaceArray(in []interface{}) []interface{} {
 
 func copyValues(in map[string]interface{}) map[string]interface{} {
 	// Marshal
-	coppiedValues, err := goyaml.Marshal(in)
-	if err != nil {
-		panic(err)
-	}
+	coppiedValues, _ := goyaml.Marshal(in)
 	// Unmarshal
 	newValues := make(map[string]interface{})
 	goyaml.Unmarshal(coppiedValues, newValues)