misc: fix hypothetical implicit memory aliasing

Signed-off-by: Hidde Beydals <hidde@hhh.computer>

Author: hiddeco

internal/controller/helmrelease_controller.go

@@ -771,13 +771,13 @@ func (r *HelmReleaseReconciler) requestsForHelmChartChange(ctx context.Context,
 	}
 
 	var reqs []reconcile.Request
-	for _, hr := range list.Items {
+	for i, hr := range list.Items {
 		// If the HelmRelease is ready and the revision of the artifact equals to the
 		// last attempted revision, we should not make a request for this HelmRelease
-		if conditions.IsReady(&hr) && hc.GetArtifact().HasRevision(hr.Status.LastAttemptedRevision) {
+		if conditions.IsReady(&list.Items[i]) && hc.GetArtifact().HasRevision(hr.Status.LastAttemptedRevision) {
 			continue
 		}
-		reqs = append(reqs, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(&hr)})
+		reqs = append(reqs, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(&list.Items[i])})
 	}
 	return reqs
 }

internal/runner/post_renderer_kustomize.go

@@ -119,14 +119,14 @@ func (k *postRendererKustomize) Run(renderedManifests *bytes.Buffer) (modifiedMa
 	}
 
 	// Add JSON 6902 patches.
-	for _, m := range k.spec.PatchesJSON6902 {
+	for i, m := range k.spec.PatchesJSON6902 {
 		patch, err := json.Marshal(m.Patch)
 		if err != nil {
 			return nil, err
 		}
 		cfg.PatchesJson6902 = append(cfg.PatchesJson6902, kustypes.Patch{
 			Patch:  string(patch),
-			Target: adaptSelector(&m.Target),
+			Target: adaptSelector(&k.spec.PatchesJSON6902[i].Target),
 		})
 	}