Skip to content

Commit cb4da0f

Browse files
authored
Merge pull request #692 from fluxcd/event-meta-token
Use last attempted values checksum as event metadata token
2 parents 9250364 + 4df753a commit cb4da0f

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

internal/controller/helmrelease_controller.go

+13-6
Original file line numberDiff line numberDiff line change
@@ -794,15 +794,22 @@ func (r *HelmReleaseReconciler) requestsForHelmChartChange(ctx context.Context,
794794

795795
// event emits a Kubernetes event and forwards the event to notification controller if configured.
796796
func (r *HelmReleaseReconciler) event(_ context.Context, hr v2.HelmRelease, revision, severity, msg string) {
797-
var meta map[string]string
798-
if revision != "" {
799-
meta = map[string]string{v2.GroupVersion.Group + "/revision": revision}
797+
var eventMeta map[string]string
798+
799+
if revision != "" || hr.Status.LastAttemptedValuesChecksum != "" {
800+
if revision != "" {
801+
eventMeta = map[string]string{v2.GroupVersion.Group + "/" + eventv1.MetaRevisionKey: revision}
802+
}
803+
if hr.Status.LastAttemptedValuesChecksum != "" {
804+
eventMeta = map[string]string{v2.GroupVersion.Group + "/" + eventv1.MetaTokenKey: hr.Status.LastAttemptedValuesChecksum}
805+
}
800806
}
801-
eventtype := "Normal"
807+
808+
eventType := corev1.EventTypeNormal
802809
if severity == eventv1.EventSeverityError {
803-
eventtype = "Warning"
810+
eventType = corev1.EventTypeWarning
804811
}
805-
r.EventRecorder.AnnotatedEventf(&hr, meta, eventtype, severity, msg)
812+
r.EventRecorder.AnnotatedEventf(&hr, eventMeta, eventType, severity, msg)
806813
}
807814

808815
func (r *HelmReleaseReconciler) recordSuspension(ctx context.Context, hr v2.HelmRelease) {

0 commit comments

Comments
 (0)