Merge pull request #254 from fluxcd/restore-buffer-size

hiddeco · web-flow · commit a15173403cdb · 2021-04-21T19:02:15.000+02:00
Restore log buffer size to 5
diff --git a/internal/runner/log_buffer.go b/internal/runner/log_buffer.go
@@ -47,7 +47,7 @@ type LogBuffer struct {
 }
 
 func NewLogBuffer(log action.DebugLog, size int) *LogBuffer {
-	if size == 0 {
+	if size <= 0 {
 		size = defaultBufferSize
 	}
 	return &LogBuffer{
diff --git a/internal/runner/runner.go b/internal/runner/runner.go
@@ -70,7 +70,7 @@ type Runner struct {
 // namespace configured to the provided values.
 func NewRunner(getter genericclioptions.RESTClientGetter, storageNamespace string, logger logr.Logger) (*Runner, error) {
 	runner := &Runner{
-		logBuffer: NewLogBuffer(NewDebugLog(logger).Log, 100),
+		logBuffer: NewLogBuffer(NewDebugLog(logger).Log, defaultBufferSize),
 	}
 	runner.config = new(action.Configuration)
 	if err := runner.config.Init(getter, storageNamespace, "secret", runner.logBuffer.Log); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ type LogBuffer struct {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`func NewLogBuffer(log action.DebugLog, size int) *LogBuffer {`
`50`		`- if size == 0 {`
	`50`	`+ if size <= 0 {`
`51`	`51`	`size = defaultBufferSize`
`52`	`52`	`}`
`53`	`53`	`return &LogBuffer{`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ type Runner struct {`
`70`	`70`	`// namespace configured to the provided values.`
`71`	`71`	`func NewRunner(getter genericclioptions.RESTClientGetter, storageNamespace string, logger logr.Logger) (*Runner, error) {`
`72`	`72`	`runner := &Runner{`
`73`		`- logBuffer: NewLogBuffer(NewDebugLog(logger).Log, 100),`
	`73`	`+ logBuffer: NewLogBuffer(NewDebugLog(logger).Log, defaultBufferSize),`
`74`	`74`	`}`
`75`	`75`	`runner.config = new(action.Configuration)`
`76`	`76`	`if err := runner.config.Init(getter, storageNamespace, "secret", runner.logBuffer.Log); err != nil {`