Merge pull request #494 from fluxcd/tidy-build-getter

hiddeco · web-flow · commit 5a7d0f853540 · 2022-06-07T14:37:09.000+02:00
diff --git a/controllers/helmrelease_controller.go b/controllers/helmrelease_controller.go
@@ -480,7 +480,6 @@ func (r *HelmReleaseReconciler) buildRESTClientGetter(ctx context.Context, hr v2
 		// If this is not configured either, this option will result in a no-op.
 		kube.WithImpersonate(hr.Spec.ServiceAccountName, hr.GetNamespace()),
 	}
-	opts = append(opts)
 	if hr.Spec.KubeConfig != nil {
 		secretName := types.NamespacedName{
 			Namespace: hr.GetNamespace(),

Original file line number	Diff line number	Diff line change
`@@ -480,7 +480,6 @@ func (r *HelmReleaseReconciler) buildRESTClientGetter(ctx context.Context, hr v2`
`480`	`480`	`// If this is not configured either, this option will result in a no-op.`
`481`	`481`	`kube.WithImpersonate(hr.Spec.ServiceAccountName, hr.GetNamespace()),`
`482`	`482`	`}`
`483`		`- opts = append(opts)`
`484`	`483`	`if hr.Spec.KubeConfig != nil {`
`485`	`484`	`secretName := types.NamespacedName{`
`486`	`485`	`Namespace: hr.GetNamespace(),`