Skip to content

Commit 2e96c92

Browse files
committed
Set --graceful-shutdown-timeout default to -1
This is the correct default value as intended in #570. xref: https://github.com/kubernetes-sigs/controller-runtime/blob/92234b3c49a315a1aed54dc0655c3570d02faa38/pkg/manager/manager.go#L292-L293 Signed-off-by: Hidde Beydals <hello@hidde.co>
1 parent 25f86bf commit 2e96c92

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

main.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func main() {
9090
flag.StringVar(&healthAddr, "health-addr", ":9440", "The address the health endpoint binds to.")
9191
flag.IntVar(&concurrent, "concurrent", 4, "The number of concurrent HelmRelease reconciles.")
9292
flag.DurationVar(&requeueDependency, "requeue-dependency", 30*time.Second, "The interval at which failing dependencies are reevaluated.")
93-
flag.DurationVar(&gracefulShutdownTimeout, "graceful-shutdown-timeout", 0, "The duration given to the reconciler to finish before forcibly stopping.")
93+
flag.DurationVar(&gracefulShutdownTimeout, "graceful-shutdown-timeout", -1, "The duration given to the reconciler to finish before forcibly stopping.")
9494
flag.BoolVar(&watchAllNamespaces, "watch-all-namespaces", true,
9595
"Watch for custom resources in all namespaces, if set to false it will only watch the runtime namespace.")
9696
flag.IntVar(&httpRetry, "http-retry", 9, "The maximum number of retries when failing to fetch artifacts over HTTP.")

0 commit comments

Comments
 (0)