Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickAccessToolBar issues in Colorful variant #845

Closed
kalatchev opened this issue Sep 3, 2020 · 3 comments
Closed

QuickAccessToolBar issues in Colorful variant #845

kalatchev opened this issue Sep 3, 2020 · 3 comments

Comments

@kalatchev
Copy link
Contributor

Background of items in QuickAccessToolBar is not changed when mouse is over them (Colorful theme variant). The dropdown button of QuickAccessToolBar is not visible when is shown bellow ribbon

Light theme (correct behaviour):

Light Colorful theme (incorrect behaviour):

Light Colorful theme (dropdown button is not visible):

In version 7.1.0 it works, however background color change was pretty pale.


Environment

  • Fluent.Ribbon 8.0.0
  • Windows 10
  • .NET Framework 3.1 Core
@batzen batzen self-assigned this Sep 4, 2020
@batzen batzen removed their assignment Oct 3, 2020
@batzen batzen self-assigned this Dec 13, 2020
@batzen batzen added this to the 9.0 milestone Dec 13, 2020
@kalatchev
Copy link
Contributor Author

Hello,

I believe that the problem is in the background of the title bar.

What I've found is that, when one uses Fluent.Ribbon and MahApps (which share the same theming), the MetroWindow and the RibbonWindow have different title bar colors. In the case of MetroWindow (MahAapps) it's the Accent color ("MahApps.Colors.Accent": "#CCxxxxxx"), on the other hand Fluent.Ribbon uses the AccentBaseColor ("Fluent.Ribbon.Colors.AccentBaseColor": "#FFxxxxxx"). I believe that the hover effect is to be achieved by using a color, darker then the current one (AccentBaseColor). Having in mind theming, I suggest transition of color from Fluent.Ribbon.Colors.AccentColor80 to Fluent.Ribbon.Colors.AccentBaseColor. And, of course, RibbonWindow should use AccentColor80 as a title bar background in colorful themes.

Another issue related to that one, is that if one uses both libraries together, particularly with the colorful theme of Fluent.Ribbon, and has child windows inherited from MetroWindow (MahApps), he will end up with windows that have different title bar colors. Recently I had such an issue and I fixed it just by setting MahApps's MetroWindow title bar background to the AccentBase (in my case I have generated my own custom color themes for both libraries with the same parameters).

As I can see, MS Office uses the same approach and deals with accent colors in that way.

I hope that somehow helps :-)

@batzen
Copy link
Member

batzen commented Jan 1, 2021

Will change TitleBackground to AccentColor80 to be aligned with MahApps.Metro. Don't know why i never noticed this difference.

There is one change that would solve all these color issues:
Switching from RGBA to pure RGB colors instead of using transparency and then fix all accent color usage to look good again.
But it would solve all issues caused by transparency/opacity used in the colors.
Will experiment a bit to see how much work this would require.

@kalatchev
Copy link
Contributor Author

Thanks a lot, @batzen

@batzen batzen closed this as completed in b2ed991 Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants