Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Numbered/Bulleted list formatting on Order Generator not displaying appropriately on Preview or after Save #10169

Closed
11 tasks
ttlenard opened this issue Oct 12, 2023 · 3 comments
Assignees
Labels

Comments

@ttlenard
Copy link
Collaborator

ttlenard commented Oct 12, 2023

Describe the Bug
A clear and concise description of what the bug is.
In the Order Generator page, if you have a numbered or bulleted list with multiple levels, it looks fine on the Generator screen, but if you preview the document or save it, the formatting changes.

For Numbered/lettered lists:
Order generator screen has number/letter combinations. On Preview or Save, it no longer has the number/letter combinations for multi-level list, it switches to all numbers. See screen grabs.

Example in editor:
Private Zenhub Image

Example in preview/generated doc:
Private Zenhub Image

For Bulleted Lists:

Order generator screen has bulleted list - all bullets are solid black. On the preview, it switches to solid/open bullets (this is actually probably desirable, but why doesn't the generator display this appropriately?)

Business Impact/Reason for Severity

In which environment did you see this bug?
Prod

Who were you logged in as?
Any Court User

What were you doing when you discovered this bug? (Using the application, demoing, smoke tests, testing other functionality, etc.)
Using the Application

To Reproduce
Steps to reproduce the behavior:

  1. Go to a case
  2. Click on the Create menu, and then select Order or Notice
  3. Select Order
  4. On the Generate tab, create a numbered and bulleted list, making sure that you have multiple levels
  5. Notice that the numbered list shows numbers/letters appropriately
  6. Notice that the bulleted list only has solid bullets
  7. Click on the Preview tab
  8. Now notice that the numbered/lettered list changes to all numbers
  9. Now notice that the bulleted list changes to solid/non-solid/square bullets

Not sure why the formatting changes between the editor and the preview/saved doc?

Expected Behavior
A clear and concise description of what you expected to happen.

  1. What is entered in the generator should be the same as in the preview or the saved document when numbered lists are used.
  2. Bulleted lists in the generator should show different types of bullets when multiple levels are used (like it currently does in the preview/saved document.

Actual Behavior
A clear and concise description of what actually happened.
What is shown in the generator is not what is displayed on the preview for both numbered/bulleted lists

Screenshots
If applicable, add screenshots to help explain your problem.

Here is a screen grab of the Order Generator - notice the numbers/letters/bullets:
Private Zenhub Image

Here is a screen grab of the Order Preview - notice that there are no more letters, and the bullets have changed.
Private Zenhub Image

Here is a screen grab of the Order after it was saved - notice that there are no more letters, and the bullets have changed.
Private Zenhub Image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Cause of Bug, If Known

Process for Logging a Bug:

  • Complete the above information
  • Add a severity tag (Critical, High Severity, Medium Severity or Low Severity). See below for priority definition.

Severity Definition:

  • Critical Defect
    Blocks entire system's or module’s functionality
    No workarounds available
    Testing cannot proceed further without bug being fixed.

  • High-severity Defect
    Affects key functionality of an application
    There's a workaround, but not obvious or easy
    App behaves in a way that is strongly different from the one stated in the requirements

  • Medium-severity Defect
    A minor function does not behave in a way stated in the requirements.
    Workaround is available and easy

  • Low-severity Defect
    Mostly related to an application’s UI
    Doesn't need a workaround, because it doesn't impact functionality

Definition of Ready for Bugs(Created 10-4-21)

Definition used: A failure or flaw in the system which produces an incorrect or undesired result that deviates from the expected result or behavior. (Note: Expected results are use cases that have been documented in past user stories as acceptance criteria and test cases, and do not include strange behavior unrelated to use cases.)

The following criteria must be met in order for the development team to begin work on the bug.

The bug must:

  • Be focused on solving a user problem
  • Contain data for all fields in the bug template, so the team can pick it up and begin working immediately

Process: If the unexpected results are new use cases that have been identified, but not yet built, new acceptance criteria and test cases should be captured in a new user story and prioritized by the product owner.

If the Court is not able to reproduce the bug, add the “Unable to reproduce” tag. This will provide visibility into the type of support that may be needed by the Court. In the event that the Court cannot reproduce the bug, the Court will work with Flexion to communicate what type of troubleshooting help may be needed.

Definition of Done (Updated 4-14-21)

Product Owner

  • Bug fix has been validated in the Court's test environment

Engineering

  • Automated test scripts have been written
  • Field level and page level validation errors (front-end and server-side) integrated and functioning
  • Verify that language for docket record for internal users and external users is identical
  • New screens have been added to pa11y scripts
  • All new functionality verified to work with keyboard and macOS voiceover https://www.apple.com/voiceover/info/guide/_1124.html
  • READMEs, other appropriate docs and swagger/APIs fully updated
  • UI should be touch optimized and responsive for external only (functions on supported mobile devices and optimized for screen sizes as required)
  • Interactors should validate entities before calling persistence methods
  • Code refactored for clarity and to remove any known technical debt
  • Deployed to the Court's test environment if prod-like data is required. Otherwise, deployed to any experimental environment for review.
@ttlenard ttlenard added bug Something isn't working WIP and removed WIP labels Oct 12, 2023
@TomElliottFlexion TomElliottFlexion self-assigned this Oct 26, 2023
@ttlenard
Copy link
Collaborator Author

ttlenard commented Oct 26, 2023

@TomElliottFlexion Some testing feedback:

I notice that the first two levels of a numbered list are working fine, but after the 2nd level, it seems to be stuck at lower-case letters. (See screen grabs below).

I also noticed that bulleted lists are now acting differently and are only displaying solid bullets on both the generator and the preview.

Notice in the screen grabs below, the generator has different number/letter combinations vs the preview. The preview it switches over to a's and b's.
Private Zenhub Image

Private Zenhub Image

@ttlenard
Copy link
Collaborator Author

@TomElliottFlexion Looks great now. Thank you!

@TomElliottFlexion
Copy link
Collaborator

PR with a little documentation: ustaxcourt#4142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

No branches or pull requests

4 participants