Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove evented util #2547

Closed
askvortsov1 opened this issue Jan 15, 2021 · 4 comments · Fixed by #3125
Closed

Deprecate and remove evented util #2547

askvortsov1 opened this issue Jan 15, 2021 · 4 comments · Fixed by #3125
Labels
Good first issue
Milestone
1.2

Comments

@askvortsov1
Copy link
Member

This util was previously used to allow the PostStream and DiscussionPage to communicate, but is now unnecessary with PostStreamState. It doesn't seem to be used in any extensions: https://query.flarum.dev/q/788d223f-4492-4ef0-ba5d-32023fa40a99
@askvortsov1 askvortsov1 changed the title Remove and deprecate evented util Deprecate and remove evented util Jan 15, 2021
@askvortsov1 askvortsov1 modified the milestones: 0.1, 1.0, 1.1 Apr 14, 2021
@prabhatjoshi321
Copy link

May i take on this Issue.

@tankerkiller125
Copy link
Contributor

@prabhatjoshi321 Go for it! If you have any questions or need help we're always around someplace.

@prabhatjoshi321
Copy link

@ tankerkiller125 Thank you, I'll start right away

@SychO9 SychO9 modified the milestones: 1.1, 1.2 Aug 25, 2021
@SychO9 SychO9 added this to Roadmap Oct 1, 2021
@fredden fredden mentioned this issue Oct 26, 2021
Merged
9 tasks
@askvortsov1
Copy link
Member Author

Deprecated stuff will be removed with the 2.0 release, we can consider this closed.

Repository owner moved this from Todo to Done in Roadmap Oct 31, 2021
@SychO9 SychO9 linked a pull request Oct 31, 2021 that will close this issue
Deprecate unused evented utility #3125
Merged
9 tasks
@SychO9 SychO9 removed this from Roadmap Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Deprecate unused evented utility fredden/flarum-core
4 participants
@tankerkiller125 @SychO9 @askvortsov1 @prabhatjoshi321