You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current Behavior
There is a mysterious semi column added underneath each extension javascript by the JsCompiler and I can't find if there's any real reason for it to be there. It's presence is not creating any problem, but it's disturbing for hackers reading the file 😛
Steps to Reproduce
Enable any extension
Open /assets/forum-<hash>.js or /assets/admin-<hash>.js
Observe the semi column (;) on its own line underneath each extension.
Those semi-columns are not part of the extension source code
For example:
This is only part of the assets file. We can see the semi column on lines 6 and 13 of this code:
I can't think of any reason for it to be there, and the git blame seems to indicate it was there from the start. It seems we could simply remove it (?)
Was it a copy-paste mistake at some point maybe ?
The text was updated successfully, but these errors were encountered:
Bug Report
Current Behavior
There is a mysterious semi column added underneath each extension javascript by the
JsCompiler
and I can't find if there's any real reason for it to be there. It's presence is not creating any problem, but it's disturbing for hackers reading the file 😛Steps to Reproduce
/assets/forum-<hash>.js
or/assets/admin-<hash>.js
;
) on its own line underneath each extension.For example:
This is only part of the assets file. We can see the semi column on lines 6 and 13 of this code:
Expected Behavior
That semi column doesn't appear to have any purpose.
Environment
Possible Solution
The semi column is added here https://github.com/flarum/core/blob/d492579638fb52dafbfe65f1f36a95eb6047f7f3/src/Frontend/Compiler/JsCompiler.php#L72 after each javascript file added through
->addFile()
.I can't think of any reason for it to be there, and the git blame seems to indicate it was there from the start. It seems we could simply remove it (?)
Was it a copy-paste mistake at some point maybe ?
The text was updated successfully, but these errors were encountered: