Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_ui_auth): pass breakpoint from RegisterScreen to LoginScreen #10607

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

PKeviin
Copy link
Contributor

@PKeviin PKeviin commented Mar 15, 2023

Description

Pass the breakpoint from RegisterScreen to LoginScreen.
Changing the breakpoint had no effect on the RegisterScreen.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@PKeviin PKeviin requested a review from lesnitsky as a code owner March 15, 2023 12:06
@google-cla
Copy link

google-cla bot commented Mar 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@PKeviin PKeviin changed the title fix(register screen): pass breakpoint to LoginScreen fix(firebase_ui_auth): pass breakpoint from RegisterScreen to LoginScreen Mar 15, 2023
@lesnitsky
Copy link
Member

@PKeviin could you please sign the CLA?

@PKeviin
Copy link
Contributor Author

PKeviin commented Mar 17, 2023

@lesnitsky It's ok

All contributors are covered under a CLA with Google

@lesnitsky lesnitsky merged commit 39d77c4 into firebase:master Mar 17, 2023
@firebase firebase locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants