-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilingual support? #379
Comments
The instructions are clear. The localized binaries are currently not shipped with the npm module. You have to build them on your own. Once that is done, you can directly use them. You can place them anywhere you want. |
I had issues building this project but just curious how big are these? I'm asking as I have tried using the ones from the CDN (in a single page app without refreshes using script.js loader) and I saw that everytime I request a new one I got ~200kb download. Also the last one wins - they conflict with each other and I'm no longer able to switch back - for example showing "en" then "de" and then I cannot show "en" one again. I can do it only if I place some random string into the url like https://www.gstatic.com/firebasejs/ui/2.7.0/firebase-ui-auth__{LANGUAGE_CODE}.js?sfsdgsdfg ... which results in another ~200kb.. |
@bojeil-google - could you clarify. What do you mean with localized binaries? I followed the instructions to the point and I have this files: I tried to add them directly in our project(without putting them in node_modules), but trying to include them in the source code with
|
I meant the |
Hm, as I said above it doesn't work for me when I paste the files in my source directory, but it works when I paste them inside node_modules/firebaseui/dist When I have them in src/dist I get
|
I was having the same problem: |
The best here if you're using NPM to import your dependencies (and especially if you are using a bundler like webpack) IMO is to use
Voila |
IMO I think it would really help to have all localized version in the NPM distrib ready-to-use and I've filed an feature request here: #242 please let's use that issue instead if you have further questions or want to share working workaround sample code in the mean time. |
I'm wondering whether I'm understanding the docs correctly: https://github.com/firebase/firebaseui-web#building-firebaseui
I've followed the steps - cloned, ran build-npm-de and in dist I have the generated tranlations. Now as far as I understand I have to place those in node_modules/firebaseui/dist ?
Is this really the way to do this? If we do it like this we no longer can do npm install/ yarn as we'll have to manually copy the localized files?
The text was updated successfully, but these errors were encountered: