Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in database.d.ts #1516

Closed
sebastianrueckerai opened this issue Jan 22, 2024 · 3 comments
Closed

Bug in database.d.ts #1516

sebastianrueckerai opened this issue Jan 22, 2024 · 3 comments

Comments

@sebastianrueckerai
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch firebase-functions@4.6.0 for the project I'm working on.

You can find details about the issue here
#1496

Here is the diff that solved my problem:

diff --git a/node_modules/firebase-functions/lib/common/providers/database.d.ts b/node_modules/firebase-functions/lib/common/providers/database.d.ts
index fe660d1..1d40471 100644
--- a/node_modules/firebase-functions/lib/common/providers/database.d.ts
+++ b/node_modules/firebase-functions/lib/common/providers/database.d.ts
@@ -97,7 +97,7 @@ export declare class DataSnapshot implements database.DataSnapshot {
      * @return `true` if enumeration was canceled due to your callback
      *   returning `true`.
      */
-    forEach(action: (a: DataSnapshot) => boolean | void): boolean;
+    forEach(action: (a: any) => boolean | void): boolean;
     /**
      * Returns `true` if the specified child path has (non-`null`) data.
      *

This issue body was partially generated by patch-package.

@google-oss-bot
Copy link
Collaborator

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@sceee
Copy link

sceee commented Jan 23, 2024

Duplicates #1513

@exaby73
Copy link
Contributor

exaby73 commented Feb 7, 2024

Fixed by #1517. I will close this issue for that reason

@exaby73 exaby73 closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants