Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure email signIn to not ask first and last name? #467

Closed
Paul776 opened this issue Dec 21, 2016 · 13 comments
Closed

Configure email signIn to not ask first and last name? #467

Paul776 opened this issue Dec 21, 2016 · 13 comments

Comments

@Paul776
Copy link

Paul776 commented Dec 21, 2016

Hi

Is it possible customise the email signup screen to not ask the first and last name ?

Thanks

@samtstern
Copy link
Contributor

@Paul776 that's not currently possible in the library but I do think that would be a good customization for the future.

The main roadblock to adding this and other minor customizations is we want to avoid filling the library with boolean flags that create more room for error (by us or by devs using the library).

@Paul776
Copy link
Author

Paul776 commented Dec 22, 2016

I understand, and yes this could be marked as an "improvement suggestion" then. As a starter that field can be either "hidden" or maybe simply give a customisation possibility to change the text label. (due to the nature of my app I'd rather call that field "nickname" than first name and last name.

@SUPERCILEX
Copy link
Collaborator

@Paul776 You can actually do that by creating a string resource overriding FirebaseUI's: <string name="name_hint">Nickname</string>.

Do watch out for new versions FirebaseUI though because they may change the ids of these string resources at anytime and without notice.

@samtstern
Copy link
Contributor

@SUPERCILEX
Copy link
Collaborator

@samtstern Ok, if #1083 goes through, we can do some crazy cool stuff! I'm not sure if we'd want this kind of feature, but I was thinking of enabling a fully customizable sign-in field template. That is, devs would be able to supply required and optional fields that we generate views for on-the-fly and use annotations and reflection to support custom validation.

The new builder APIs in my PR would enable this kind of customization that could be used to build conference apps or something else that requires many fields. What do you think? If you like the idea, I'd whip up a PR so we can have it ready by v3.2.0.

@samtstern
Copy link
Contributor

@SUPERCILEX let's first offer a long-awaited flag for this particular issue, release 3.2.0 and then do further features based on demand. I don't really like the words "crazy" and "reflection" used together in a feature proposal :-)

@samtstern samtstern added this to the 3.2.0 milestone Jan 3, 2018
@SUPERCILEX
Copy link
Collaborator

@samtstern Haha, that SGTM. At least the doors will be open now! 😁

@Kurt29
Copy link

Kurt29 commented Jan 4, 2018

@SUPERCILEX
That would be the feature that I actually wanted/needed for a long time. But since I am still not done with other parts of my app, I was too lazy to actually try to implement this.

@Levelleor
Copy link

Is this issue still can't be fixed? Same here as someone already said. "First & last name" simply sounds weird in my app and might scare people to type anything.

@samtstern
Copy link
Contributor

@Levelleor this is on the 3.2.0 milestone which means we hope to close it in our next release. @SUPERCILEX did some refactoring to make this possible.

@samtstern
Copy link
Contributor

@SUPERCILEX this is the last bug on the 3.2.0 hotlist that is not fix-implemented. We should probably implement this and then release 3.2.0, get some of the new architecture out into the wild before racing ahead any further.

@samtstern samtstern self-assigned this Jan 18, 2018
@SUPERCILEX
Copy link
Collaborator

@samtstern Yup, SGTM!

@samtstern
Copy link
Contributor

This has been fixed and released in version 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants