Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirebaseAuth UI country code selection scrollbar not implemented right. #1192

Closed
srujanb opened this issue Mar 17, 2018 · 2 comments
Closed

Comments

@srujanb
Copy link

srujanb commented Mar 17, 2018

Step 2: Describe your environment

  • Android device: OnePlus
  • Android OS version: 8.0
  • Google Play Services version: 11.8.0
  • Firebase/Play Services SDK version: 11.8.0
  • FirebaseUI version: 3.2.1

Step 3: Describe the problem:

The scrollbar should not go beyond the screen when scrolling happens on the dialog box. See the scrollbar in the video below.

https://youtu.be/t2xaA-M0t-E

Steps to reproduce:

  1. Implement firebaseUI auth.
  2. Include SMS auth builder
  3. Click on the list of countries to select country code.
  4. Scroll
  5. Get annoyed with the scrollbar going all the way to the bottom, out of the screen.

Observed Results:

See the Scrollbar in the video.

https://youtu.be/t2xaA-M0t-E

Expected Results:

Scrollbar not going beyond screen

Relevant Code:

None.

@SUPERCILEX
Copy link
Collaborator

Yeah, the whole phone auth codebase is in a sad place right now. We're getting very close to a complete rewrite which will give us the freedom to use stuff like the recycler view and whatnot to improve that kind of UX. I was actually thinking of making it a bottom sheet since the spinner takes up the entire screen anyway. It'll get there! 😊

@samtstern
Copy link
Contributor

This has been fixed and released in version 4.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants