fix: minor staticcheck fixes

Author: rvagg

impl/events.go

@@ -38,7 +38,7 @@ func (m *manager) OnChannelOpened(chid datatransfer.ChannelID) error {
 // back a pause to the transport if the data limit is exceeded
 func (m *manager) OnDataReceived(chid datatransfer.ChannelID, link ipld.Link, size uint64, index int64, unique bool) error {
 	ctx, _ := m.spansIndex.SpanForChannel(context.TODO(), chid)
-	ctx, span := otel.Tracer("data-transfer").Start(ctx, "dataReceived", trace.WithAttributes(
+	_, span := otel.Tracer("data-transfer").Start(ctx, "dataReceived", trace.WithAttributes(
 		attribute.String("channelID", chid.String()),
 		attribute.String("link", link.String()),
 		attribute.Int64("index", index),
@@ -69,7 +69,7 @@ func (m *manager) OnDataQueued(chid datatransfer.ChannelID, link ipld.Link, size
 	// machine.
 
 	ctx, _ := m.spansIndex.SpanForChannel(context.TODO(), chid)
-	ctx, span := otel.Tracer("data-transfer").Start(ctx, "dataQueued", trace.WithAttributes(
+	_, span := otel.Tracer("data-transfer").Start(ctx, "dataQueued", trace.WithAttributes(
 		attribute.String("channelID", chid.String()),
 		attribute.String("link", link.String()),
 		attribute.Int64("size", int64(size)),
@@ -91,7 +91,7 @@ func (m *manager) OnDataQueued(chid datatransfer.ChannelID, link ipld.Link, size
 func (m *manager) OnDataSent(chid datatransfer.ChannelID, link ipld.Link, size uint64, index int64, unique bool) error {
 
 	ctx, _ := m.spansIndex.SpanForChannel(context.TODO(), chid)
-	ctx, span := otel.Tracer("data-transfer").Start(ctx, "dataSent", trace.WithAttributes(
+	_, span := otel.Tracer("data-transfer").Start(ctx, "dataSent", trace.WithAttributes(
 		attribute.String("channelID", chid.String()),
 		attribute.String("link", link.String()),
 		attribute.Int64("size", int64(size)),

impl/impl.go

@@ -198,7 +198,7 @@ func (m *manager) OpenPushDataChannel(ctx context.Context, requestTo peer.ID, vo
 	m.dataTransferNetwork.Protect(requestTo, chid.String())
 	monitoredChan := m.channelMonitor.AddPushChannel(chid)
 	if err := m.dataTransferNetwork.SendMessage(ctx, requestTo, req); err != nil {
-		err = fmt.Errorf("Unable to send request: %w", err)
+		err = fmt.Errorf("unable to send request: %w", err)
 		span.RecordError(err)
 		span.SetStatus(codes.Error, err.Error())
 		_ = m.channels.Error(chid, err)
@@ -239,7 +239,7 @@ func (m *manager) OpenPullDataChannel(ctx context.Context, requestTo peer.ID, vo
 	m.dataTransferNetwork.Protect(requestTo, chid.String())
 	monitoredChan := m.channelMonitor.AddPullChannel(chid)
 	if err := m.transport.OpenChannel(ctx, requestTo, chid, cidlink.Link{Cid: baseCid}, selector, nil, req); err != nil {
-		err = fmt.Errorf("Unable to send request: %w", err)
+		err = fmt.Errorf("unable to send request: %w", err)
 		span.RecordError(err)
 		span.SetStatus(codes.Error, err.Error())
 		_ = m.channels.Error(chid, err)
@@ -278,7 +278,7 @@ func (m *manager) SendVoucher(ctx context.Context, channelID datatransfer.Channe
 		return err
 	}
 	if err := m.dataTransferNetwork.SendMessage(ctx, chst.OtherPeer(), updateRequest); err != nil {
-		err = fmt.Errorf("Unable to send request: %w", err)
+		err = fmt.Errorf("unable to send request: %w", err)
 		_ = m.OnRequestDisconnected(channelID, err)
 		span.RecordError(err)
 		span.SetStatus(codes.Error, err.Error())
@@ -317,7 +317,7 @@ func (m *manager) SendVoucherResult(ctx context.Context, channelID datatransfer.
 		return err
 	}
 	if err := m.dataTransferNetwork.SendMessage(ctx, chst.OtherPeer(), updateResponse); err != nil {
-		err = fmt.Errorf("Unable to send request: %w", err)
+		err = fmt.Errorf("unable to send request: %w", err)
 		_ = m.OnRequestDisconnected(channelID, err)
 		span.RecordError(err)
 		span.SetStatus(codes.Error, err.Error())
@@ -540,7 +540,7 @@ func (m *manager) PauseDataTransferChannel(ctx context.Context, chid datatransfe
 	}
 
 	if err := m.dataTransferNetwork.SendMessage(ctx, chid.OtherParty(m.peerID), m.pauseMessage(chid)); err != nil {
-		err = fmt.Errorf("Unable to send pause message: %w", err)
+		err = fmt.Errorf("unable to send pause message: %w", err)
 		_ = m.OnRequestDisconnected(chid, err)
 		return err
 	}

impl/integration_test.go

@@ -49,7 +49,8 @@ const loremFile = "lorem.txt"
 const loremFileTransferBytes = 20439
 
 const loremLargeFile = "lorem_large.txt"
-const loremLargeFileTransferBytes = 217452
+
+// const loremLargeFileTransferBytes = 217452
 
 // nil means use the default protocols
 // tests data transfer for the following protocol combinations:
@@ -1921,6 +1922,7 @@ func TestRespondingToPullGraphsyncRequests(t *testing.T) {
 				request, err := message.NewRequest(id, false, true, &voucher, testutil.GenerateCids(1)[0], gsData.AllSelector)
 				require.NoError(t, err)
 				nd, err := request.ToIPLD()
+				require.NoError(t, err)
 				gsRequest := gsmsg.NewRequest(graphsync.NewRequestID(), link.(cidlink.Link).Cid, gsData.AllSelector, graphsync.Priority(rand.Int31()), graphsync.ExtensionData{
 					Name: extension.ExtensionDataTransfer1_1,
 					Data: nd,