build: fix lints

Author: phodal

.eslintrc.json

@@ -6,8 +6,8 @@
     {
       "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
       "rules": {
-        "@typescript-eslint/no-unused-vars": "off",
         "prefer-const": "warn",
+        "@typescript-eslint/no-unused-vars": "off",
         "@nrwl/nx/enforce-module-boundaries": [
           "error",
           {
@@ -26,7 +26,9 @@
     {
       "files": ["*.ts", "*.tsx"],
       "extends": ["plugin:@nrwl/nx/typescript"],
-      "rules": {}
+      "rules": {
+        "prefer-const": "warn"
+      }
     },
     {
       "files": ["*.js", "*.jsx"],

package-lock.json

@@ -6,5 +6,8 @@
     "cheerio": "^1.0.0-rc.12",
     "pako": "^2.0.4",
     "xml-js": "^1.6.11"
+  },
+  "devDependencies": {
+    "@types/pako": "^2.0.0"
   }
 }

packages/feakin-exporter/package.json

@@ -5,24 +5,24 @@ describe('MxGraphEncoder', () => {
   it('should work', () => {
     const sampleStr =
       '<mxfile host="Electron" modified="2022-07-26T06:50:38.916Z" agent="5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) draw.io/19.0.3 Chrome/102.0.5005.63 Electron/19.0.3 Safari/537.36" etag="S-i-T2jFARcjY2b3OQvQ" version="19.0.3" type="device"><diagram id="bN4dli3-ZhfTxRglmdzi" name="Page-1">jZJNT8QgEIZ/DUcTWlbdPdp11Rj1YA97NKSMhQRKw1Lb+uulduhHNpvsieGZD2begbC96Z4dr+W7FaBJSkVH2CNJ0yTdbcMxkH4k2106gtIpgUEzyNUvIKRIGyXgtAr01mqv6jUsbFVB4VeMO2fbddi31etXa17CGcgLrs/pUQkvcYpbOvMXUKWMLycUPYbHYAQnyYVtF4gdCNs7a/1omW4PehAv6jLmPV3wTo05qPw1CQ+feUk39r4zx+yL5R/ZK7zdYJUfrhscGJv1fVTA2aYSMBShhGWtVB7ymheDtw07D0x6o8MtCSaWA+ehu9hnMk0fvg1YA971IQQT2B0Khj9mw/DezvonUVS50D7mcVx5OZWeVQkGChOv8wL+fYtvzA5/</diagram></mxfile>';
-    let data = MxGraphEncode.decodeXml(sampleStr);
+    const data = MxGraphEncode.decodeXml(sampleStr);
     expect(data?.startsWith('<mxGraphModel')).toBeTruthy();
   });
 
   it('encode with decode', () => {
-    let source = '<mxGraphModel><root><mxCell id="0"/></root></mxGraphModel>';
-    let encoded = MxGraphEncode.encode(source);
-    let decoded = MxGraphEncode.decode(encoded);
+    const source = '<mxGraphModel><root><mxCell id="0"/></root></mxGraphModel>';
+    const encoded = MxGraphEncode.encode(source);
+    const decoded = MxGraphEncode.decode(encoded);
     expect(decoded).toEqual(source);
   });
 
   it('text from hello world', () => {
     const sampleStr =
       '<mxfile host="Electron" modified="2022-07-26T12:42:39.225Z" agent="5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) draw.io/19.0.3 Chrome/102.0.5005.63 Electron/19.0.3 Safari/537.36" etag="O1qmAbmb6dEBzrUx5KlV" version="19.0.3" type="device"><diagram id="bN4dli3-ZhfTxRglmdzi" name="Page-1">jZNNT4QwEIZ/i4ceTYDuh1cX190Y9SCHPZqGjrRJYbAUYf31lm270BgTL2T6vPPRzgyE5vV40KwVL8hBkSzhI6EPJMvWq9R+J3B2gG4zByotuUPpDAr5DR4mnvaSQxc5GkRlZBvDEpsGShMxpjUOsdsHqrhqyyr4BYqSqd/0JLkRjt6tk5kfQVYiVE4Tr9QsOHvQCcZxWCC6JzTXiMZZ9ZiDmnoX+uLiHv9QrxfT0Jj/BNy/FVWywu1Yn3bvtHjdPcHzrc/yxVTvH0yyjbL5dq0Ga1aTGVDXsmZqtWKd6+rms8eLMJsh5miLI8ly6z+gVvwmJLEXdHni3BZHFS8dM+cwBo19w2F6SWLlQUgDRcvKSR3s3lkmTK3sKb1GLzsTngnawLhAvlMHwBqMPlsXr9KNn5pf2xX152FegjRMViwWIMQxv3fVNfU8Gmv46YTjvAUXbfEr0f0P</diagram></mxfile>';
-    let encoded = MxGraphEncode.decodeXml(sampleStr);
+    const encoded = MxGraphEncode.decodeXml(sampleStr);
 
-    let xmlInJson: MxGraph = MxGraphEncode.xml2obj(encoded!);
-    let mxCell = xmlInJson.mxGraphModel.root.mxCell;
+    const xmlInJson: MxGraph = MxGraphEncode.xml2obj(encoded!);
+    const mxCell = xmlInJson.mxGraphModel.root.mxCell;
 
     expect(xmlInJson.mxGraphModel.root.mxCell.length).toBe(3);
     expect(mxCell[2].value!.includes('Hello, world!')).toBeTruthy();

packages/feakin-exporter/src/target/mxgraph/mxgraph-encode.spec.ts

@@ -1,20 +1,16 @@
-import * as cheerio from 'cheerio';
-import { xml2json } from 'xml-js';
-
-const convert = require('xml-js');
-
-const pako = require('pako');
+import cheerio from 'cheerio';
+import * as convert from 'xml-js';
+import * as pako from 'pako';
 
 const MxGraphEncode = {
   xml2json: (xml: string) => {
     return convert.xml2js(xml, {
       compact: true,
-      spaces: 4,
       alwaysChildren: true,
     });
   },
   inlineAttrs: function (obj: any) {
-    for (let prop in obj) {
+    for (const prop in obj) {
       if (typeof obj[prop] == 'object') {
         if (obj[prop]._attributes) {
           Object.assign(obj[prop], obj[prop]._attributes);
@@ -34,9 +30,8 @@ const MxGraphEncode = {
   },
   decodeXml: (source: string) => {
     const $ = MxGraphEncode.parseXml(source);
-    let mxfile = $('mxfile');
+    const mxfile = $('mxfile');
     if (mxfile) {
-      // @ts-ignore
       const diagrams = cheerio.text($('mxfile diagram'));
 
       if (diagrams.length > 0) {
@@ -57,16 +52,15 @@ const MxGraphEncode = {
   },
   encode: (source: string) => {
     const data = encodeURIComponent(source);
-    const compressed = pako.deflateRaw(data, { to: 'string' });
+    const compressed = pako.deflateRaw(data);
     const base64 = btoa(MxGraphEncode.arrayBufferToString(compressed));
     return base64;
   },
   arrayBufferToString: (array: ArrayBuffer) => {
     let result = '';
-    array = new Uint8Array(array);
-    for (let c = array.byteLength, d = 0; d < c; d++) {
-      // @ts-ignore
-      result += String.fromCharCode(array[d]);
+    const uint8Array = new Uint8Array(array);
+    for (let c = uint8Array.byteLength, d = 0; d < c; d++) {
+      result += String.fromCharCode(uint8Array[d]);
     }
     return result;
   },

packages/feakin-exporter/src/target/mxgraph/mxgraph-encode.ts

@@ -10,13 +10,21 @@
     "importHelpers": true,
     "target": "es2015",
     "module": "esnext",
-    "lib": ["es2017", "dom"],
+    "lib": [
+      "es2017",
+      "dom"
+    ],
     "skipLibCheck": true,
     "skipDefaultLibCheck": true,
     "baseUrl": "./feakin",
     "paths": {
-      "@feakin/feakin-exporter": ["packages/feakin-exporter/src/index.ts"]
+      "@feakin/feakin-exporter": [
+        "packages/feakin-exporter/src/index.ts"
+      ]
     }
   },
-  "exclude": ["feakin/node_modules", "tmp"]
+  "exclude": [
+    "feakin/node_modules",
+    "tmp"
+  ]
 }