Skip to content
This repository has been archived by the owner on Oct 2, 2018. It is now read-only.

New exportArchive Feature #83

Merged
merged 17 commits into from
Sep 18, 2015
Merged

New exportArchive Feature #83

merged 17 commits into from
Sep 18, 2015

Conversation

KrauseFx
Copy link
Contributor

Follow up on #79

This was referenced Sep 16, 2015
Closed
Closed
houndci-bot
houndci-bot reviewed Sep 16, 2015
View reviewed changes
spec/package_command_generator_xcode7_spec.rb
"/usr/bin/xcrun xcodebuild -exportArchive",
"-exportOptionsPlist '#{Gym::PackageCommandGeneratorXcode7.config_path}'",
"-archivePath '#{Gym::BuildCommandGenerator.archive_path}'",
"-exportPath '#{Gym::BuildCommandGenerator.build_path}'",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

This was referenced Sep 17, 2015
Closed
Closed
ldiqual
ldiqual reviewed Sep 17, 2015
View reviewed changes
lib/gym/options.rb
FastlaneCore::ConfigItem.new(key: :skip_symbols,
short_option: "-m",
env_name: "GYM_SKIP_SYMBOLS",
description: "Should the ipa file *not* include symbols?",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for using a negation in the flag name here? Seems confusing, especially when the actual archive flag (uploadSymbols) doesn't have a negation. How about GYM_UPLOAD_SYMBOLS with default false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good point, thank you so much @ldiqual 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for that was, that you can't pass a false value from the command line right now.

@ldiqual
Copy link

ldiqual commented Sep 18, 2015

This looks really good, I'm excited to see this in master! I believe the new archiver will need to use this hack to support swift apps: http://stackoverflow.com/a/32535087/646960. Without it, I wasn't able to submit my binaries because of a validation error (the infamous Invalid swift support). I added this simple bash command in my script:

build_archive() # xcodebuild archive

cp "${TMP_ARCHIVE_PATH}.xcarchive/SwiftSupport/iphoneos"/libswift*.dylib \
    "${TMP_ARCHIVE_PATH}.xcarchive/Products/Applications/${PRODUCT_NAME}.app/Frameworks/"

generate_ipa() # New -exportArchive command

Let me know if you need some extra hands, I'll be happy to help.

houndci-bot
houndci-bot reviewed Sep 18, 2015
View reviewed changes
lib/gym/xcodebuild_fixes/swift_fix.rb
@@ -1,3 +1,7 @@
# encoding: utf-8
# from http://stackoverflow.com/a/9857493/445598
# because of
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected.

KrauseFx added a commit that referenced this pull request Sep 18, 2015
@KrauseFx
Merge pull request #83 from fastlane/develop
842b449 
New exportArchive Feature
@KrauseFx KrauseFx merged commit 842b449 into master Sep 18, 2015
@lacostej
Copy link
Contributor

+1 thanks @KrauseFx

@KrauseFx
Copy link
Contributor Author

Yeah, thanks @lacostej for preparing everything 👍

@fastlane-bot-helper fastlane-bot-helper mentioned this pull request Mar 7, 2016
Closed
@fastlanebot fastlanebot mentioned this pull request Mar 8, 2016
Closed
@fastlane-old fastlane-old locked and limited conversation to collaborators Mar 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KrauseFx @ldiqual @lacostej @houndci-bot