Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbdev_install_quarto may install and remove unrelated packages #1182

Closed
sswam opened this issue Oct 24, 2022 · 1 comment · Fixed by #1208
Closed

nbdev_install_quarto may install and remove unrelated packages #1182

sswam opened this issue Oct 24, 2022 · 1 comment · Fixed by #1208
Labels
bug Something isn't working

Comments

@sswam
Copy link

sswam commented Oct 24, 2022

I ran nbdev_install_quarto and was surprised to see dpkg installing several unrelated .deb packages, which happened to be in my cwd.

This code is responsible:

system(f'curl -LO {BASE_QUARTO_URL}quarto-linux-amd64.deb')
system('sudo dpkg -i *64.deb && rm *64.deb')

Fortuantely I pressed ctrl-C when I saw this happening, as the next command would have deleted those packages. It's not really cool for a helpful script to annihilate files with a broad glob from the user's current directory. In my case it would have been 3.1GB of Nvidia stuff.

Suggested fix:

system('sudo dpkg -i quarto-linux-amd64.deb && rm quarto-linux-amd64.deb')

@sswam sswam changed the title nbdev_install_quarto on Linux installs any other random .deb that happens to be in the cwd nbdev_install_quarto on Linux installs all other random .deb packages that happen to be in the cwd, then deletes them all Oct 24, 2022
@seeM seeM added the bug Something isn't working label Oct 24, 2022
@seeM seeM changed the title nbdev_install_quarto on Linux installs all other random .deb packages that happen to be in the cwd, then deletes them all nbdev_install_quarto may install and remove unrelated packages Nov 8, 2022
@seeM
Copy link
Contributor

seeM commented Nov 8, 2022

Wow, nice catch! Thanks for reporting this!

@seeM seeM closed this as completed in #1208 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants