Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_:hammer_and_wrench: Refactor suggestion_ #7

Open
farmisen opened this issue Feb 13, 2025 · 0 comments
Open

_:hammer_and_wrench: Refactor suggestion_ #7

farmisen opened this issue Feb 13, 2025 · 0 comments

Comments

@farmisen
Copy link
Owner

          _:hammer_and_wrench: Refactor suggestion_

Method signatures are well documented, but error handling needs update.

The method signatures with type hints are clear and helpful. However, there's a discrepancy in the error handling section.

The error handling example uses requests.exceptions.HTTPError but the client uses httpx. Update the error handling section to use the correct exception:

-from requests.exceptions import HTTPError
+from httpx import HTTPError

try:
    api.upload_files(file)
except HTTPError as e:

Committable suggestion skipped: line range outside the PR's diff.

Originally posted by @coderabbitai[bot] in #6 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant