Skip to content

Commit c8a5e33

Browse files
uli42sunweaver
authored andcommitted
Suppress false positives in static analysis
there's more work to do... The whole nx-X11/extras dir is no longer checked since we only have Mesa there and we do not want to check that mess... All the exceptions in static-analysis-suppressions have been manually checked.
1 parent b91b3d8 commit c8a5e33

File tree

2 files changed

+28
-2
lines changed

2 files changed

+28
-2
lines changed

run-static-analysis.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ if [[ "${STATIC_ANALYSIS}" == "yes" ]]; then
66
echo 'Error: cppcheck is not installed.' >&2
77
exit 1
88
fi
9-
CPPCHECK_OPTS='--error-exitcode=0 --force --quiet'
9+
CPPCHECK_OPTS='--error-exitcode=0 --force --quiet --suppressions-list=./static-analysis-suppressions'
1010
# we exclude some external projects
11-
CPPCHECK_EXCLUDES='-i ./nx-X11/extras/Mesa* -i ./nx-X11/extras/Mesa_* -i nx-X11/programs/Xserver/GL/mesa*'
11+
CPPCHECK_EXCLUDES='-i ./nx-X11/extras/ -i nx-X11/programs/Xserver/GL/mesa* -i ./.pc -i ./nx-X11/.build-exports -i ./nx-X11/exports -i ./doc'
1212
echo "$(cppcheck --version):";
1313
cppcheck $CPPCHECK_OPTS $CPPCHECK_EXCLUDES .;
1414
fi

static-analysis-suppressions

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
memleak:nx-X11/programs/Xserver/dix/gc.c
2+
memleak:nx-X11/lib/include/xtrans/Xtrans.c:982
3+
memleak:nx-X11/lib/include/xtrans/Xtrans.c:987
4+
memleak:nx-X11/lib/include/xtrans/Xtrans.c:1004
5+
memleak:nx-X11/lib/include/xtrans/Xtrans.c:1009
6+
uninitvar:nx-X11/lib/include/xtrans/Xtranssock.c:1107
7+
uninitvar:nx-X11/lib/include/xtrans/Xtranssock.c:1109
8+
uninitvar:nx-X11/lib/include/xtrans/Xtranssock.c:1146
9+
uninitvar:nx-X11/lib/include/xtrans/Xtranssock.c:1148
10+
memleak:nx-X11/lib/include/xtrans/Xtranssock.c:2446
11+
memleak:nx-X11/lib/include/xtrans/Xtranssock.c:2458
12+
nullPointer:nx-X11/programs/Xserver/Xext/security.c
13+
nullPointerArithmetic:nx-X11/programs/Xserver/randr/rrcrtc.c
14+
nullPointerArithmetic:nx-X11/programs/Xserver/randr/rroutput.c
15+
nullPointerArithmetic:nx-X11/programs/Xserver/randr/rrprovider.c
16+
nullPointerArithmetic:nx-X11/programs/Xserver/randr/rrscreen.c
17+
memleak:nx-X11/programs/Xserver/render/render.c:2929
18+
memleak:nx-X11/programs/Xserver/render/render.c:2991
19+
memleak:nx-X11/programs/Xserver/render/render.c:3049
20+
memleak:nx-X11/programs/Xserver/render/render.c:3103
21+
memleak:nx-X11/programs/Xserver/render/render.c:3157
22+
memleak:nx-X11/programs/Xserver/render/render.c:3288
23+
doubleFree:nx-X11/programs/Xserver/hw/nxagent/Keyboard.c:1699
24+
uninitStructMember:nx-X11/programs/Xserver/mi/miwideline.c:190
25+
invalidFree:nxcomp/src/EncodeBuffer.cpp:84
26+
invalidFree:nxcomp/src/EncodeBuffer.cpp:106

0 commit comments

Comments
 (0)