-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more v1 methods to v2 client #55
Conversation
3095b5f
to
991987d
Compare
list_project_grant_members
method
991987d
to
3d3fdf8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
========================================
+ Coverage 3.19% 4.00% +0.80%
========================================
Files 857 856 -1
Lines 36616 36535 -81
========================================
+ Hits 1171 1462 +291
+ Misses 35445 35073 -372 see 31 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but I'm not a big fan of sneaking in a bunch of refactoring with a feature commit.
I avoid being too precise with this because it can be a ton of work for more hairy commits, but in this case it should be really trivial. Can we split this into two commits, one with the refactor and another with the new method?
I agree, initially I added the support for org id in headers, which required changing all the lines where |
3d3fdf8
to
d9b5213
Compare
We should try to add proper sorting to these methods upstream. |
5902a82
to
27bb811
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the unboxing of the PaginationHandler
, thanks for taking your time to do that.
src/v2/management/models/management_service_list_project_grant_members_body.rs
Outdated
Show resolved
Hide resolved
b652bb3
to
3b91640
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go except for one detail that almost slipped by me?
9031cd5
to
a846e9d
Compare
a846e9d
to
db8877d
Compare
db8877d
to
4fd53b5
Compare
list_project_grant_members
method
No description provided.