From 6f92de9cef499b8c189cefc333710ef59d7ffca9 Mon Sep 17 00:00:00 2001 From: Heinrich Kuttler Date: Thu, 23 Jul 2020 12:46:48 +0200 Subject: [PATCH 1/2] Require cmake version >= 3.17. Upgrading from cmake version 3.13.1 made this error go away: CMake Error at CMakeLists.txt:67 (install): install TARGETS given no RUNTIME DESTINATION for executable target "nethack". --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ee2344efa..072a5e17a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.12) +cmake_minimum_required(VERSION 3.17) file(STRINGS "version.txt" NLE_VERSION) project(nle VERSION ${NLE_VERSION}) message(STATUS "Building nle backend version: ${NLE_VERSION}") From 63a6ab793353edf9c162faa544eaca452e775687 Mon Sep 17 00:00:00 2001 From: Heinrich Kuttler Date: Thu, 23 Jul 2020 12:56:36 +0200 Subject: [PATCH 2/2] Actually require only cmake version >= 3.14. Easy as pi! --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 072a5e17a..613e51929 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.17) +cmake_minimum_required(VERSION 3.14) file(STRINGS "version.txt" NLE_VERSION) project(nle VERSION ${NLE_VERSION}) message(STATUS "Building nle backend version: ${NLE_VERSION}")