Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning for deprecated storage in Pytroch interface #3273

Closed
mdouze opened this issue Mar 1, 2024 · 1 comment
Closed

Fix warning for deprecated storage in Pytroch interface #3273

mdouze opened this issue Mar 1, 2024 · 1 comment

Comments

@mdouze
Copy link
Contributor

mdouze commented Mar 1, 2024

Summary

For all methods that use the torch_utils package, there is a warning

faiss/contrib/torch_utils.py:44: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()

This is annoying and will break in the future, so let's address this (we tried to do it before, but it did break with older pytorch)

@ramilbakhshyiev
Copy link
Contributor

Fixed in #3301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants