Skip to content

Commit d6ad6ca

Browse files
Enable most of C++ tests on ROCm
Summary: ROCm build successfully passes all but 2 GPU tests and we want to enable the passing test on CI while skipping the 2 failing tests to make progress. The 2 failing tests are failing specifically on the hardware type that we use for our runners and the AMD team is actively working on root causing it and providing a fix: `TestGpuIndexIVFPQ.Query_L2_MMCodeDistance` `TestGpuIndexIVFPQ.Query_IP_MMCodeDistance` Differential Revision: D61688657
1 parent 5c87f13 commit d6ad6ca

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/actions/build_cmake/action.yml

-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ runs:
131131
.
132132
make -k -C build -j$(nproc)
133133
- name: C++ tests
134-
if: inputs.rocm == 'OFF'
135134
shell: bash
136135
run: |
137136
export GTEST_OUTPUT="xml:$(realpath .)/test-results/googletest/"

faiss/gpu/test/TestGpuIndexIVFPQ.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -306,14 +306,15 @@ void testMMCodeDistance(faiss::MetricType mt) {
306306
opt.getPctMaxDiffN());
307307
}
308308
}
309-
309+
#ifndef FAISS_ENABLE_ROCM
310310
TEST(TestGpuIndexIVFPQ, Query_L2_MMCodeDistance) {
311311
testMMCodeDistance(faiss::MetricType::METRIC_L2);
312312
}
313313

314314
TEST(TestGpuIndexIVFPQ, Query_IP_MMCodeDistance) {
315315
testMMCodeDistance(faiss::MetricType::METRIC_INNER_PRODUCT);
316316
}
317+
#endif // FAISS_ENABLE_ROCM
317318

318319
TEST(TestGpuIndexIVFPQ, Float16Coarse) {
319320
Options opt;

0 commit comments

Comments
 (0)