Skip to content

Commit d40b39a

Browse files
Nit: fix variable types (#3147)
Summary: The inconsistency in variable types would generate waaaaaaay too many warnings `comparison of integer expressions of different signedness` during the compilation if all the warnings are made reported Pull Request resolved: #3147 Reviewed By: mlomeli1 Differential Revision: D51988074 Pulled By: algoriddle fbshipit-source-id: 31a57bbe3a14105a968d3f06c0807c2fe60f1a62
1 parent aebc1d5 commit d40b39a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

faiss/impl/pq4_fast_scan_search_1.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ void accumulate_fixed_blocks(
125125
ResultHandler& res,
126126
const Scaler& scaler) {
127127
constexpr int bbs = 32 * BB;
128-
for (int64_t j0 = 0; j0 < nb; j0 += bbs) {
128+
for (size_t j0 = 0; j0 < nb; j0 += bbs) {
129129
FixedStorageHandler<NQ, 2 * BB> res2;
130130
kernel_accumulate_block<NQ, BB>(nsq, codes, LUT, res2, scaler);
131131
res.set_block_origin(0, j0);

faiss/impl/pq4_fast_scan_search_qbs.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ void accumulate_q_4step(
123123
constexpr int Q4 = (QBS >> 12) & 15;
124124
constexpr int SQ = Q1 + Q2 + Q3 + Q4;
125125

126-
for (int64_t j0 = 0; j0 < ntotal2; j0 += 32) {
126+
for (size_t j0 = 0; j0 < ntotal2; j0 += 32) {
127127
FixedStorageHandler<SQ, 2> res2;
128128
const uint8_t* LUT = LUT0;
129129
kernel_accumulate_block<Q1>(nsq, codes, LUT, res2, scaler);
@@ -156,7 +156,7 @@ void kernel_accumulate_block_loop(
156156
const uint8_t* LUT,
157157
ResultHandler& res,
158158
const Scaler& scaler) {
159-
for (int64_t j0 = 0; j0 < ntotal2; j0 += 32) {
159+
for (size_t j0 = 0; j0 < ntotal2; j0 += 32) {
160160
res.set_block_origin(0, j0);
161161
kernel_accumulate_block<NQ, ResultHandler>(
162162
nsq, codes + j0 * nsq / 2, LUT, res, scaler);
@@ -243,7 +243,7 @@ void pq4_accumulate_loop_qbs(
243243

244244
// default implementation where qbs is not known at compile time
245245

246-
for (int64_t j0 = 0; j0 < ntotal2; j0 += 32) {
246+
for (size_t j0 = 0; j0 < ntotal2; j0 += 32) {
247247
const uint8_t* LUT = LUT0;
248248
int qi = qbs;
249249
int i0 = 0;

0 commit comments

Comments
 (0)