Skip to content

Commit d2692b8

Browse files
kuarorafacebook-github-bot
authored andcommitted
Small nits and formatting (#3907)
Summary: Pull Request resolved: #3907 same as title. Fix checking right desc Reviewed By: satymish Differential Revision: D63854967 fbshipit-source-id: b8bc48662bc38ac96cf9241bdbe2be2b23f1a37e
1 parent caa3b34 commit d2692b8

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

benchs/bench_fw/benchmark.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -874,13 +874,14 @@ def create_gt_knn(self, knn_desc, search=True) -> Optional[KnnDescriptor]:
874874
if self.search_op:
875875
gt_knn_desc = self.search_op.get_flat_desc(knn_desc.flat_name())
876876
if gt_knn_desc is None:
877-
if knn_desc.index_desc is not None:
877+
if knn_desc.gt_index_desc is not None:
878878
gt_index_desc = knn_desc.gt_index_desc
879879
else:
880880
gt_index_desc = self.build_op.get_flat_desc(
881881
knn_desc.index_desc.flat_name()
882882
)
883883
knn_desc.gt_index_desc = gt_index_desc
884+
884885
assert gt_index_desc is not None
885886
gt_knn_desc = KnnDescriptor(
886887
d=knn_desc.d,

benchs/bench_fw/index.py

+5-6
Original file line numberDiff line numberDiff line change
@@ -735,9 +735,6 @@ def add_range_or_val(name, range):
735735
if self.search_params and name in self.search_params
736736
else range
737737
),
738-
[self.search_params[name]]
739-
if self.search_params and name in self.search_params
740-
else range,
741738
)
742739

743740
add_range_or_val("snap", [0])
@@ -1023,9 +1020,11 @@ def get_quantizer(self, dry_run, pretransform=None):
10231020
d=model_ivf.quantizer.d,
10241021
metric=model_ivf.quantizer.metric_type,
10251022
database_vectors=centroids,
1026-
construction_params=self.construction_params[1:]
1027-
if self.construction_params is not None
1028-
else None,
1023+
construction_params=(
1024+
self.construction_params[1:]
1025+
if self.construction_params is not None
1026+
else None
1027+
),
10291028
search_params=None,
10301029
factory=reverse_index_factory(model_ivf.quantizer),
10311030
training_vectors=centroids,

0 commit comments

Comments
 (0)