Skip to content

Commit 58a673d

Browse files
Enable most of C++ tests on ROCm (#3786)
Summary: Pull Request resolved: #3786 ROCm build successfully passes all but 2 GPU tests and we want to enable the passing test on CI while skipping the 2 failing tests to make progress. The 2 failing tests are failing specifically on the hardware type that we use for our runners and the AMD team is actively working on root causing it and providing a fix: `TestGpuIndexIVFPQ.Query_L2_MMCodeDistance` `TestGpuIndexIVFPQ.Query_IP_MMCodeDistance` Reviewed By: asadoughi Differential Revision: D61688657 fbshipit-source-id: 3fedfcf22a0ccf40ac8aff033e8bc09c4eb0cbd5
1 parent 6053348 commit 58a673d

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.github/actions/build_cmake/action.yml

-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,6 @@ runs:
131131
.
132132
make -k -C build -j$(nproc)
133133
- name: C++ tests
134-
if: inputs.rocm == 'OFF'
135134
shell: bash
136135
run: |
137136
export GTEST_OUTPUT="xml:$(realpath .)/test-results/googletest/"

faiss/gpu/test/TestGpuIndexIVFPQ.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -307,13 +307,16 @@ void testMMCodeDistance(faiss::MetricType mt) {
307307
}
308308
}
309309

310+
// FIXME: https://github.com/facebookresearch/faiss/issues/3787
311+
#ifndef USE_AMD_ROCM
310312
TEST(TestGpuIndexIVFPQ, Query_L2_MMCodeDistance) {
311313
testMMCodeDistance(faiss::MetricType::METRIC_L2);
312314
}
313315

314316
TEST(TestGpuIndexIVFPQ, Query_IP_MMCodeDistance) {
315317
testMMCodeDistance(faiss::MetricType::METRIC_INNER_PRODUCT);
316318
}
319+
#endif // USE_AMD_ROCM
317320

318321
TEST(TestGpuIndexIVFPQ, Float16Coarse) {
319322
Options opt;

0 commit comments

Comments
 (0)