Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent changes break code #22

Open
andrewpeng02 opened this issue Feb 17, 2025 · 1 comment
Open

Recent changes break code #22

andrewpeng02 opened this issue Feb 17, 2025 · 1 comment

Comments

@andrewpeng02
Copy link

Hi, this commit change breaks generation, eval, and likely other scripts because in transformers v4.46, position_embeddings is a required field, but it isn't passed in forward_early or forward_remaining. See https://github.com/huggingface/transformers/blob/53fad641cfdb5105e2470bcf3ef17ea8e25cc300/src/transformers/models/llama/modeling_llama.py#L369

@mostafaelhoushi
Copy link
Collaborator

Because forward_early and forward_remainder are basically a copy of Hugging Face transformers LlamaDecoder's forward() function,it's vulnerable to any internal implementation changes in the transformers library.

I did try to work on fixing that in the update-transformers branch. I can try to look into this but if someone else can give it a try that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants