From b1760a64523e9d17642b4c03167936e631008a2d Mon Sep 17 00:00:00 2001 From: Chris Cummins Date: Fri, 19 Mar 2021 12:22:44 +0000 Subject: [PATCH] [examples] Put helper functions in anonymous namespace. --- .../example_compiler_gym_service/service_cc/ExampleService.cc | 4 ++-- .../example_compiler_gym_service/service_cc/ExampleService.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/examples/example_compiler_gym_service/service_cc/ExampleService.cc b/examples/example_compiler_gym_service/service_cc/ExampleService.cc index b6cef9c760..6ba724e040 100644 --- a/examples/example_compiler_gym_service/service_cc/ExampleService.cc +++ b/examples/example_compiler_gym_service/service_cc/ExampleService.cc @@ -27,8 +27,6 @@ template return Status::OK; } -} // namespace - std::vector getBenchmarks() { return {"foo", "bar"}; } std::vector getActionSpaces() { @@ -69,6 +67,8 @@ std::vector getObservationSpaces() { return {ir, features, runtime}; } +} // namespace + ExampleService::ExampleService(const fs::path& workingDirectory) : workingDirectory_(workingDirectory), nextSessionId_(0) {} diff --git a/examples/example_compiler_gym_service/service_cc/ExampleService.h b/examples/example_compiler_gym_service/service_cc/ExampleService.h index 3f87cfabb6..ed0633b480 100644 --- a/examples/example_compiler_gym_service/service_cc/ExampleService.h +++ b/examples/example_compiler_gym_service/service_cc/ExampleService.h @@ -74,8 +74,4 @@ class ExampleCompilationSession { ActionSpace actionSpace_; }; -// Helper functions to describe the available action/observation/reward spaces. -std::vector getActionSpaces(); -std::vector getObservationSpaces(); - } // namespace compiler_gym::example_service