Skip to content

Commit d10f1de

Browse files
committed
Ported LevelDB's fault_injection_test
Summary: This is a port of [[ https://github.com/google/leveldb/blob/master/db/fault_injection_test.cc | LevelDB's fault_injection_test ]] to RocksDB. Unfortunately it fails with: ``` ==== Test FaultInjectionTest.FaultTest db/fault_injection_test.cc:491: Corruption: no meta-nextfile entry in descriptor #0 ./fault_injection_test() [0x41477a] rocksdb::FaultInjectionTest::PartialCompactTestReopenWithFault(rocksdb::FaultInjectionTest::ResetMethod, int, int) /data/users/tomdzk/rocksdb/db/fault_injection_test.cc:491 #1 ./fault_injection_test() [0x40a38a] rocksdb::_Test_FaultTest::_Run() /data/users/tomdzk/rocksdb/db/fault_injection_test.cc:517 #2 ./fault_injection_test() [0x415bea] rocksdb::_Test_FaultTest::_RunIt() /data/users/tomdzk/rocksdb/db/fault_injection_test.cc:507 #3 ./fault_injection_test() [0x584367] rocksdb::test::RunAllTests() /data/users/tomdzk/rocksdb/util/testharness.cc:70 #4 /usr/local/fbcode/gcc-4.8.1-glibc-2.17/lib/libc.so.6(__libc_start_main+0x10e) [0x7f7a40857efe] ?? ??:0 #5 ./fault_injection_test() [0x408bb8] _start ??:0 ``` so I commented out the test invocation in the source code for now (lines 514-520) so it can be merged. Test Plan: This is a new test. Reviewers: igor Reviewed By: igor Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D31587
1 parent 2bb0590 commit d10f1de

File tree

2 files changed

+546
-1
lines changed

2 files changed

+546
-1
lines changed

Makefile

+5-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ else
4343
OPT += -DNDEBUG
4444
endif
4545

46-
ifneq ($(filter -DROCKSDB_LITE,$(OPT)),)
46+
ifneq ($(filter -DROCKSDB_LITE,$(OPT)),)
4747
# found
4848
CFLAGS += -fno-exceptions
4949
CXXFLAGS += -fno-exceptions
@@ -121,6 +121,7 @@ TESTS = \
121121
crc32c_test \
122122
dbformat_test \
123123
env_test \
124+
fault_injection_test \
124125
blob_store_test \
125126
filelock_test \
126127
filename_test \
@@ -462,6 +463,9 @@ dbformat_test: db/dbformat_test.o $(LIBOBJECTS) $(TESTHARNESS)
462463
env_test: util/env_test.o $(LIBOBJECTS) $(TESTHARNESS)
463464
$(CXX) util/env_test.o $(LIBOBJECTS) $(TESTHARNESS) $(EXEC_LDFLAGS) -o $@ $(LDFLAGS) $(COVERAGEFLAGS)
464465

466+
fault_injection_test: db/fault_injection_test.o $(LIBOBJECTS) $(TESTHARNESS)
467+
$(CXX) db/fault_injection_test.o $(LIBOBJECTS) $(TESTHARNESS) $(EXEC_LDFLAGS) -o $@ $(LDFLAGS) $(COVERAGEFLAGS)
468+
465469
rate_limiter_test: util/rate_limiter_test.o $(LIBOBJECTS) $(TESTHARNESS)
466470
$(CXX) util/rate_limiter_test.o $(LIBOBJECTS) $(TESTHARNESS) $(EXEC_LDFLAGS) -o $@ $(LDFLAGS) $(COVERAGEFLAGS)
467471

0 commit comments

Comments
 (0)