Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel #31554

sebmarkbage · 2024-11-15T20:40:06Z

This lets us track separately if something was suspended on an Action using useActionState rather than suspended on Data.

This approach feels quite bloated and it seems like we'd eventually might want to read more information about the Promise that suspended and the context it suspended in. As a more general reason for suspending.

The way useActionState works in combination with the prewarming is quite unfortunate because 1) it renders blocking to update the isPending flag whether you use it or not 2) it prewarms and suspends the useActionState 3) then it does another third render to get back into the useActionState position again.

…seActionException sentinel This lets us track separately if something was suspended on an Action using useActionState.

vercel · 2024-11-15T20:40:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 8:43pm

sebmarkbage · 2024-11-15T20:42:34Z

packages/react-reconciler/src/ReactFiberHooks.js

+      if (x === SuspenseException) {
+        // If we Suspend here, mark this separately so that we can track this
+        // as an Action in Profiling tools.
+        throw SuspenseActionException;


This is where the magic happens.

yeah meh this is fine 😆

react-sizebot · 2024-11-15T20:43:16Z

Comparing: 0480cdb...bc6e288

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.js	=	6.68 kB	6.68 kB	=	1.83 kB	1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js	+0.13%	509.08 kB	509.76 kB	+0.12%	91.00 kB	91.11 kB
oss-experimental/react-dom/cjs/react-dom.production.js	=	6.69 kB	6.69 kB	=	1.83 kB	1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js	+0.13%	514.01 kB	514.69 kB	+0.13%	91.71 kB	91.83 kB
facebook-www/ReactDOM-prod.classic.js	+0.13%	588.65 kB	589.38 kB	+0.12%	104.18 kB	104.30 kB
facebook-www/ReactDOM-prod.modern.js	+0.13%	578.91 kB	579.65 kB	+0.13%	102.59 kB	102.72 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable-rc/react-test-renderer/cjs/react-test-renderer.production.js	+0.30%	308.29 kB	309.21 kB	+0.18%	54.54 kB	54.64 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js	+0.30%	308.29 kB	309.21 kB	+0.18%	54.54 kB	54.64 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js	+0.30%	308.36 kB	309.27 kB	+0.18%	54.56 kB	54.66 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js	+0.30%	308.54 kB	309.46 kB	+0.19%	54.59 kB	54.70 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js	+0.28%	325.64 kB	326.57 kB	+0.18%	57.34 kB	57.44 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js	+0.27%	347.61 kB	348.55 kB	+0.19%	60.42 kB	60.53 kB
react-native/implementations/ReactFabric-prod.fb.js	+0.26%	373.90 kB	374.89 kB	+0.18%	65.49 kB	65.61 kB
react-native/implementations/ReactFabric-prod.js	+0.26%	354.10 kB	355.02 kB	+0.16%	61.98 kB	62.09 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js	+0.26%	379.51 kB	380.50 kB	+0.18%	66.58 kB	66.70 kB
react-native/implementations/ReactNativeRenderer-prod.js	+0.25%	362.51 kB	363.43 kB	+0.17%	63.37 kB	63.48 kB
react-native/implementations/ReactFabric-profiling.fb.js	+0.25%	399.56 kB	400.57 kB	+0.17%	69.37 kB	69.49 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js	+0.25%	405.14 kB	406.14 kB	+0.18%	70.45 kB	70.57 kB
react-native/implementations/ReactFabric-profiling.js	+0.25%	379.50 kB	380.44 kB	+0.18%	65.61 kB	65.73 kB
react-native/implementations/ReactNativeRenderer-profiling.js	+0.24%	387.91 kB	388.84 kB	+0.18%	67.19 kB	67.31 kB
oss-stable-rc/react-art/cjs/react-art.production.js	+0.23%	298.49 kB	299.17 kB	+0.23%	51.31 kB	51.43 kB
oss-stable-semver/react-art/cjs/react-art.production.js	+0.23%	298.49 kB	299.17 kB	+0.23%	51.31 kB	51.43 kB
oss-stable/react-art/cjs/react-art.production.js	+0.23%	298.55 kB	299.23 kB	+0.23%	51.33 kB	51.45 kB
oss-experimental/react-art/cjs/react-art.production.js	+0.22%	303.07 kB	303.75 kB	+0.25%	52.09 kB	52.22 kB
facebook-www/ReactART-prod.modern.js	+0.21%	352.02 kB	352.76 kB	+0.19%	59.60 kB	59.72 kB
facebook-www/ReactART-prod.classic.js	+0.21%	361.74 kB	362.49 kB	+0.17%	61.17 kB	61.27 kB
oss-stable-rc/react-art/cjs/react-art.development.js	+0.20%	553.83 kB	554.96 kB	+0.17%	89.65 kB	89.81 kB
oss-stable-semver/react-art/cjs/react-art.development.js	+0.20%	553.83 kB	554.96 kB	+0.17%	89.65 kB	89.81 kB
oss-stable/react-art/cjs/react-art.development.js	+0.20%	553.89 kB	555.02 kB	+0.17%	89.68 kB	89.83 kB

Generated by 🚫 dangerJS against 404fb64

…seActionException sentinel (#31554) This lets us track separately if something was suspended on an Action using useActionState rather than suspended on Data. This approach feels quite bloated and it seems like we'd eventually might want to read more information about the Promise that suspended and the context it suspended in. As a more general reason for suspending. The way useActionState works in combination with the prewarming is quite unfortunate because 1) it renders blocking to update the isPending flag whether you use it or not 2) it prewarms and suspends the useActionState 3) then it does another third render to get back into the useActionState position again. DiffTrain build for [92c0f5f](92c0f5f)

Summary: X-link: facebook/metro#1400 - **[372ec00c03](facebook/react@372ec00c03 )**: Update ReactDebugInfo types to declare timing info separately ([facebook#31714](facebook/react#31714)) //<Sebastian Markbåge>// - **[3d2ab01a55](facebook/react@3d2ab01a55 )**: [Flight] Extract special cases for Server Component return value position ([facebook#31713](facebook/react#31713)) //<Sebastian Markbåge>// - **[1c9b138714](facebook/react@1c9b138714 )**: Don't serialize chunk ids for Hint and Console rows ([facebook#31671](facebook/react#31671)) //<Sebastian Markbåge>// - **[de68d2f4a2](facebook/react@de68d2f4a2 )**: Register Suspense retry handlers in commit phase ([facebook#31667](facebook/react#31667)) //<Josh Story>// - **[16d2bbbd1f](facebook/react@16d2bbbd1f )**: Client render dehydrated Suspense boundaries on document load ([facebook#31620](facebook/react#31620)) //<Josh Story>// - **[5b0ef217ef](facebook/react@5b0ef217ef )**: s/server action/server function ([facebook#31005](facebook/react#31005)) //<Ricky>// - **[e3b7ef32be](facebook/react@e3b7ef32be )**: [crud] Only export uRC when flag is enabled ([facebook#31617](facebook/react#31617)) //<lauren>// - **[aba370f1e4](facebook/react@aba370f1e4 )**: Add moveBefore Experiment ([facebook#31596](facebook/react#31596)) //<Sebastian Markbåge>// - **[1345c37941](facebook/react@1345c37941 )**: Mark all lanes in order on every new render ([facebook#31615](facebook/react#31615)) //<Sebastian Markbåge>// - **[91061073d5](facebook/react@91061073d5 )**: Mark ping time as update ([facebook#31611](facebook/react#31611)) //<Sebastian Markbåge>// - **[a9f14cb44e](facebook/react@a9f14cb44e )**: Fix Logging of Immediately Resolved Promises ([facebook#31610](facebook/react#31610)) //<Sebastian Markbåge>// - **[c11c9510fa](facebook/react@c11c9510fa )**: [crud] Fix deps comparison bug ([facebook#31599](facebook/react#31599)) //<lauren>// - **[64f89510af](facebook/react@64f89510af )**: [crud] Enable on RTR FB builds ([facebook#31590](facebook/react#31590)) //<lauren>// - **[7558ffe84d](facebook/react@7558ffe84d )**: [crud] Fix copy paste typo ([facebook#31588](facebook/react#31588)) //<lauren>// - **[7c254b6576](facebook/react@7c254b6576 )**: Log yielded time in the Component Track ([facebook#31563](facebook/react#31563)) //<Sebastian Markbåge>// - **[6177b18c66](facebook/react@6177b18c66 )**: Track suspended time when the render doesn't commit because it suspended ([facebook#31552](facebook/react#31552)) //<Sebastian Markbåge>// - **[eaf2d5c670](facebook/react@eaf2d5c670 )**: fix[eslint-plugin-react-hooks]: Fix error when callback argument is an identifier with an `as` expression ([facebook#31119](facebook/react#31119)) //<Mark Skelton>// - **[047d95e85f](facebook/react@047d95e85f )**: [crud] Basic implementation ([facebook#31523](facebook/react#31523)) //<lauren>// - **[92c0f5f85f](facebook/react@92c0f5f85f )**: Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel ([facebook#31554](facebook/react#31554)) //<Sebastian Markbåge>// - **[053b3cb050](facebook/react@053b3cb050 )**: [crud] Rename Effect type ([facebook#31557](facebook/react#31557)) //<lauren>// - **[7dd6b9e68a](facebook/react@7dd6b9e68a )**: [crud] Add enableUseResourceEffectHook flag ([facebook#31556](facebook/react#31556)) //<lauren>// - **[d8afd1c82e](facebook/react@d8afd1c82e )**: [crud] Scaffold initial types ([facebook#31555](facebook/react#31555)) //<lauren>// - **[3720870a97](facebook/react@3720870a97 )**: Log Render Phases that Never Committed ([facebook#31548](facebook/react#31548)) //<Sebastian Markbåge>// - **[8a41d6ceab](facebook/react@8a41d6ceab )**: Unify RootDidNotComplete and RootSuspendedWithDelay exit path ([facebook#31547](facebook/react#31547)) //<Sebastian Markbåge>// - **[63cde684f5](facebook/react@63cde684f5 )**: (chore): copy fix in <style> precedence error ([facebook#31524](facebook/react#31524)) //<Zack Tanner>// - **[b01722d585](facebook/react@b01722d585 )**: Format event with "warning" yellow and prefix with "Event: " ([facebook#31536](facebook/react#31536)) //<Sebastian Markbåge>// - **[c13986da78](facebook/react@c13986da78 )**: Fix Overlapping "message" Bug in Performance Track ([facebook#31528](facebook/react#31528)) //<Sebastian Markbåge>// - **[4686872159](facebook/react@4686872159 )**: Log passive commit phase when it wasn't delayed ([facebook#31526](facebook/react#31526)) //<Sebastian Markbåge>// - **[5d89471ca6](facebook/react@5d89471ca6 )**: Export __COMPILER_RUNTIME in stable ([facebook#31540](facebook/react#31540)) //<lauren>// - **[3644f0bd21](facebook/react@3644f0bd21 )**: Use completedRenderEndTime as the start of the commit phase if it's an immediate commit ([facebook#31527](facebook/react#31527)) //<Sebastian Markbåge>// - **[8657869999](facebook/react@8657869999 )**: Separate Tracks for Components and Phases ([facebook#31525](facebook/react#31525)) //<Sebastian Markbåge>// - **[b15135b9f5](facebook/react@b15135b9f5 )**: [ez] Update useMemoCache return type ([facebook#31539](facebook/react#31539)) //<lauren>// Changelog: [General][Changed] - Bump React from 18.3.1 to 19.0.0 jest_e2e[run_all_tests] Reviewed By: cortinico Differential Revision: D67018480

Summary: X-link: facebook/react-native#48196 - **[372ec00c03](facebook/react@372ec00c03 )**: Update ReactDebugInfo types to declare timing info separately ([#31714](facebook/react#31714)) //<Sebastian Markbåge>// - **[3d2ab01a55](facebook/react@3d2ab01a55 )**: [Flight] Extract special cases for Server Component return value position ([#31713](facebook/react#31713)) //<Sebastian Markbåge>// - **[1c9b138714](facebook/react@1c9b138714 )**: Don't serialize chunk ids for Hint and Console rows ([#31671](facebook/react#31671)) //<Sebastian Markbåge>// - **[de68d2f4a2](facebook/react@de68d2f4a2 )**: Register Suspense retry handlers in commit phase ([#31667](facebook/react#31667)) //<Josh Story>// - **[16d2bbbd1f](facebook/react@16d2bbbd1f )**: Client render dehydrated Suspense boundaries on document load ([#31620](facebook/react#31620)) //<Josh Story>// - **[5b0ef217ef](facebook/react@5b0ef217ef )**: s/server action/server function ([#31005](facebook/react#31005)) //<Ricky>// - **[e3b7ef32be](facebook/react@e3b7ef32be )**: [crud] Only export uRC when flag is enabled ([#31617](facebook/react#31617)) //<lauren>// - **[aba370f1e4](facebook/react@aba370f1e4 )**: Add moveBefore Experiment ([#31596](facebook/react#31596)) //<Sebastian Markbåge>// - **[1345c37941](facebook/react@1345c37941 )**: Mark all lanes in order on every new render ([#31615](facebook/react#31615)) //<Sebastian Markbåge>// - **[91061073d5](facebook/react@91061073d5 )**: Mark ping time as update ([#31611](facebook/react#31611)) //<Sebastian Markbåge>// - **[a9f14cb44e](facebook/react@a9f14cb44e )**: Fix Logging of Immediately Resolved Promises ([#31610](facebook/react#31610)) //<Sebastian Markbåge>// - **[c11c9510fa](facebook/react@c11c9510fa )**: [crud] Fix deps comparison bug ([#31599](facebook/react#31599)) //<lauren>// - **[64f89510af](facebook/react@64f89510af )**: [crud] Enable on RTR FB builds ([#31590](facebook/react#31590)) //<lauren>// - **[7558ffe84d](facebook/react@7558ffe84d )**: [crud] Fix copy paste typo ([#31588](facebook/react#31588)) //<lauren>// - **[7c254b6576](facebook/react@7c254b6576 )**: Log yielded time in the Component Track ([#31563](facebook/react#31563)) //<Sebastian Markbåge>// - **[6177b18c66](facebook/react@6177b18c66 )**: Track suspended time when the render doesn't commit because it suspended ([#31552](facebook/react#31552)) //<Sebastian Markbåge>// - **[eaf2d5c670](facebook/react@eaf2d5c670 )**: fix[eslint-plugin-react-hooks]: Fix error when callback argument is an identifier with an `as` expression ([#31119](facebook/react#31119)) //<Mark Skelton>// - **[047d95e85f](facebook/react@047d95e85f )**: [crud] Basic implementation ([#31523](facebook/react#31523)) //<lauren>// - **[92c0f5f85f](facebook/react@92c0f5f85f )**: Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel ([#31554](facebook/react#31554)) //<Sebastian Markbåge>// - **[053b3cb050](facebook/react@053b3cb050 )**: [crud] Rename Effect type ([#31557](facebook/react#31557)) //<lauren>// - **[7dd6b9e68a](facebook/react@7dd6b9e68a )**: [crud] Add enableUseResourceEffectHook flag ([#31556](facebook/react#31556)) //<lauren>// - **[d8afd1c82e](facebook/react@d8afd1c82e )**: [crud] Scaffold initial types ([#31555](facebook/react#31555)) //<lauren>// - **[3720870a97](facebook/react@3720870a97 )**: Log Render Phases that Never Committed ([#31548](facebook/react#31548)) //<Sebastian Markbåge>// - **[8a41d6ceab](facebook/react@8a41d6ceab )**: Unify RootDidNotComplete and RootSuspendedWithDelay exit path ([#31547](facebook/react#31547)) //<Sebastian Markbåge>// - **[63cde684f5](facebook/react@63cde684f5 )**: (chore): copy fix in <style> precedence error ([#31524](facebook/react#31524)) //<Zack Tanner>// - **[b01722d585](facebook/react@b01722d585 )**: Format event with "warning" yellow and prefix with "Event: " ([#31536](facebook/react#31536)) //<Sebastian Markbåge>// - **[c13986da78](facebook/react@c13986da78 )**: Fix Overlapping "message" Bug in Performance Track ([#31528](facebook/react#31528)) //<Sebastian Markbåge>// - **[4686872159](facebook/react@4686872159 )**: Log passive commit phase when it wasn't delayed ([#31526](facebook/react#31526)) //<Sebastian Markbåge>// - **[5d89471ca6](facebook/react@5d89471ca6 )**: Export __COMPILER_RUNTIME in stable ([#31540](facebook/react#31540)) //<lauren>// - **[3644f0bd21](facebook/react@3644f0bd21 )**: Use completedRenderEndTime as the start of the commit phase if it's an immediate commit ([#31527](facebook/react#31527)) //<Sebastian Markbåge>// - **[8657869999](facebook/react@8657869999 )**: Separate Tracks for Components and Phases ([#31525](facebook/react#31525)) //<Sebastian Markbåge>// - **[b15135b9f5](facebook/react@b15135b9f5 )**: [ez] Update useMemoCache return type ([#31539](facebook/react#31539)) //<lauren>// Changelog: [General][Changed] - Bump React from 18.3.1 to 19.0.0 jest_e2e[run_all_tests] Reviewed By: cortinico Differential Revision: D67018480

Summary: X-link: facebook/metro#1400 - **[372ec00c03](facebook/react@372ec00c03 )**: Update ReactDebugInfo types to declare timing info separately ([facebook#31714](facebook/react#31714)) //<Sebastian Markbåge>// - **[3d2ab01a55](facebook/react@3d2ab01a55 )**: [Flight] Extract special cases for Server Component return value position ([facebook#31713](facebook/react#31713)) //<Sebastian Markbåge>// - **[1c9b138714](facebook/react@1c9b138714 )**: Don't serialize chunk ids for Hint and Console rows ([facebook#31671](facebook/react#31671)) //<Sebastian Markbåge>// - **[de68d2f4a2](facebook/react@de68d2f4a2 )**: Register Suspense retry handlers in commit phase ([facebook#31667](facebook/react#31667)) //<Josh Story>// - **[16d2bbbd1f](facebook/react@16d2bbbd1f )**: Client render dehydrated Suspense boundaries on document load ([facebook#31620](facebook/react#31620)) //<Josh Story>// - **[5b0ef217ef](facebook/react@5b0ef217ef )**: s/server action/server function ([facebook#31005](facebook/react#31005)) //<Ricky>// - **[e3b7ef32be](facebook/react@e3b7ef32be )**: [crud] Only export uRC when flag is enabled ([facebook#31617](facebook/react#31617)) //<lauren>// - **[aba370f1e4](facebook/react@aba370f1e4 )**: Add moveBefore Experiment ([facebook#31596](facebook/react#31596)) //<Sebastian Markbåge>// - **[1345c37941](facebook/react@1345c37941 )**: Mark all lanes in order on every new render ([facebook#31615](facebook/react#31615)) //<Sebastian Markbåge>// - **[91061073d5](facebook/react@91061073d5 )**: Mark ping time as update ([facebook#31611](facebook/react#31611)) //<Sebastian Markbåge>// - **[a9f14cb44e](facebook/react@a9f14cb44e )**: Fix Logging of Immediately Resolved Promises ([facebook#31610](facebook/react#31610)) //<Sebastian Markbåge>// - **[c11c9510fa](facebook/react@c11c9510fa )**: [crud] Fix deps comparison bug ([facebook#31599](facebook/react#31599)) //<lauren>// - **[64f89510af](facebook/react@64f89510af )**: [crud] Enable on RTR FB builds ([facebook#31590](facebook/react#31590)) //<lauren>// - **[7558ffe84d](facebook/react@7558ffe84d )**: [crud] Fix copy paste typo ([facebook#31588](facebook/react#31588)) //<lauren>// - **[7c254b6576](facebook/react@7c254b6576 )**: Log yielded time in the Component Track ([facebook#31563](facebook/react#31563)) //<Sebastian Markbåge>// - **[6177b18c66](facebook/react@6177b18c66 )**: Track suspended time when the render doesn't commit because it suspended ([facebook#31552](facebook/react#31552)) //<Sebastian Markbåge>// - **[eaf2d5c670](facebook/react@eaf2d5c670 )**: fix[eslint-plugin-react-hooks]: Fix error when callback argument is an identifier with an `as` expression ([facebook#31119](facebook/react#31119)) //<Mark Skelton>// - **[047d95e85f](facebook/react@047d95e85f )**: [crud] Basic implementation ([facebook#31523](facebook/react#31523)) //<lauren>// - **[92c0f5f85f](facebook/react@92c0f5f85f )**: Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel ([facebook#31554](facebook/react#31554)) //<Sebastian Markbåge>// - **[053b3cb050](facebook/react@053b3cb050 )**: [crud] Rename Effect type ([facebook#31557](facebook/react#31557)) //<lauren>// - **[7dd6b9e68a](facebook/react@7dd6b9e68a )**: [crud] Add enableUseResourceEffectHook flag ([facebook#31556](facebook/react#31556)) //<lauren>// - **[d8afd1c82e](facebook/react@d8afd1c82e )**: [crud] Scaffold initial types ([facebook#31555](facebook/react#31555)) //<lauren>// - **[3720870a97](facebook/react@3720870a97 )**: Log Render Phases that Never Committed ([facebook#31548](facebook/react#31548)) //<Sebastian Markbåge>// - **[8a41d6ceab](facebook/react@8a41d6ceab )**: Unify RootDidNotComplete and RootSuspendedWithDelay exit path ([facebook#31547](facebook/react#31547)) //<Sebastian Markbåge>// - **[63cde684f5](facebook/react@63cde684f5 )**: (chore): copy fix in <style> precedence error ([facebook#31524](facebook/react#31524)) //<Zack Tanner>// - **[b01722d585](facebook/react@b01722d585 )**: Format event with "warning" yellow and prefix with "Event: " ([facebook#31536](facebook/react#31536)) //<Sebastian Markbåge>// - **[c13986da78](facebook/react@c13986da78 )**: Fix Overlapping "message" Bug in Performance Track ([facebook#31528](facebook/react#31528)) //<Sebastian Markbåge>// - **[4686872159](facebook/react@4686872159 )**: Log passive commit phase when it wasn't delayed ([facebook#31526](facebook/react#31526)) //<Sebastian Markbåge>// - **[5d89471ca6](facebook/react@5d89471ca6 )**: Export __COMPILER_RUNTIME in stable ([facebook#31540](facebook/react#31540)) //<lauren>// - **[3644f0bd21](facebook/react@3644f0bd21 )**: Use completedRenderEndTime as the start of the commit phase if it's an immediate commit ([facebook#31527](facebook/react#31527)) //<Sebastian Markbåge>// - **[8657869999](facebook/react@8657869999 )**: Separate Tracks for Components and Phases ([facebook#31525](facebook/react#31525)) //<Sebastian Markbåge>// - **[b15135b9f5](facebook/react@b15135b9f5 )**: [ez] Update useMemoCache return type ([facebook#31539](facebook/react#31539)) //<lauren>// Changelog: [General][Changed] - Bump React from 18.3.1 to 19.0.0 jest_e2e[run_all_tests] Reviewed By: cortinico Differential Revision: D67018480

Summary: Pull Request resolved: facebook#48196 X-link: facebook/metro#1400 - **[372ec00c03](facebook/react@372ec00c03 )**: Update ReactDebugInfo types to declare timing info separately ([facebook#31714](facebook/react#31714)) //<Sebastian Markbåge>// - **[3d2ab01a55](facebook/react@3d2ab01a55 )**: [Flight] Extract special cases for Server Component return value position ([facebook#31713](facebook/react#31713)) //<Sebastian Markbåge>// - **[1c9b138714](facebook/react@1c9b138714 )**: Don't serialize chunk ids for Hint and Console rows ([facebook#31671](facebook/react#31671)) //<Sebastian Markbåge>// - **[de68d2f4a2](facebook/react@de68d2f4a2 )**: Register Suspense retry handlers in commit phase ([facebook#31667](facebook/react#31667)) //<Josh Story>// - **[16d2bbbd1f](facebook/react@16d2bbbd1f )**: Client render dehydrated Suspense boundaries on document load ([facebook#31620](facebook/react#31620)) //<Josh Story>// - **[5b0ef217ef](facebook/react@5b0ef217ef )**: s/server action/server function ([facebook#31005](facebook/react#31005)) //<Ricky>// - **[e3b7ef32be](facebook/react@e3b7ef32be )**: [crud] Only export uRC when flag is enabled ([facebook#31617](facebook/react#31617)) //<lauren>// - **[aba370f1e4](facebook/react@aba370f1e4 )**: Add moveBefore Experiment ([facebook#31596](facebook/react#31596)) //<Sebastian Markbåge>// - **[1345c37941](facebook/react@1345c37941 )**: Mark all lanes in order on every new render ([facebook#31615](facebook/react#31615)) //<Sebastian Markbåge>// - **[91061073d5](facebook/react@91061073d5 )**: Mark ping time as update ([facebook#31611](facebook/react#31611)) //<Sebastian Markbåge>// - **[a9f14cb44e](facebook/react@a9f14cb44e )**: Fix Logging of Immediately Resolved Promises ([facebook#31610](facebook/react#31610)) //<Sebastian Markbåge>// - **[c11c9510fa](facebook/react@c11c9510fa )**: [crud] Fix deps comparison bug ([facebook#31599](facebook/react#31599)) //<lauren>// - **[64f89510af](facebook/react@64f89510af )**: [crud] Enable on RTR FB builds ([facebook#31590](facebook/react#31590)) //<lauren>// - **[7558ffe84d](facebook/react@7558ffe84d )**: [crud] Fix copy paste typo ([facebook#31588](facebook/react#31588)) //<lauren>// - **[7c254b6576](facebook/react@7c254b6576 )**: Log yielded time in the Component Track ([facebook#31563](facebook/react#31563)) //<Sebastian Markbåge>// - **[6177b18c66](facebook/react@6177b18c66 )**: Track suspended time when the render doesn't commit because it suspended ([facebook#31552](facebook/react#31552)) //<Sebastian Markbåge>// - **[eaf2d5c670](facebook/react@eaf2d5c670 )**: fix[eslint-plugin-react-hooks]: Fix error when callback argument is an identifier with an `as` expression ([facebook#31119](facebook/react#31119)) //<Mark Skelton>// - **[047d95e85f](facebook/react@047d95e85f )**: [crud] Basic implementation ([facebook#31523](facebook/react#31523)) //<lauren>// - **[92c0f5f85f](facebook/react@92c0f5f85f )**: Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel ([facebook#31554](facebook/react#31554)) //<Sebastian Markbåge>// - **[053b3cb050](facebook/react@053b3cb050 )**: [crud] Rename Effect type ([facebook#31557](facebook/react#31557)) //<lauren>// - **[7dd6b9e68a](facebook/react@7dd6b9e68a )**: [crud] Add enableUseResourceEffectHook flag ([facebook#31556](facebook/react#31556)) //<lauren>// - **[d8afd1c82e](facebook/react@d8afd1c82e )**: [crud] Scaffold initial types ([facebook#31555](facebook/react#31555)) //<lauren>// - **[3720870a97](facebook/react@3720870a97 )**: Log Render Phases that Never Committed ([facebook#31548](facebook/react#31548)) //<Sebastian Markbåge>// - **[8a41d6ceab](facebook/react@8a41d6ceab )**: Unify RootDidNotComplete and RootSuspendedWithDelay exit path ([facebook#31547](facebook/react#31547)) //<Sebastian Markbåge>// - **[63cde684f5](facebook/react@63cde684f5 )**: (chore): copy fix in <style> precedence error ([facebook#31524](facebook/react#31524)) //<Zack Tanner>// - **[b01722d585](facebook/react@b01722d585 )**: Format event with "warning" yellow and prefix with "Event: " ([facebook#31536](facebook/react#31536)) //<Sebastian Markbåge>// - **[c13986da78](facebook/react@c13986da78 )**: Fix Overlapping "message" Bug in Performance Track ([facebook#31528](facebook/react#31528)) //<Sebastian Markbåge>// - **[4686872159](facebook/react@4686872159 )**: Log passive commit phase when it wasn't delayed ([facebook#31526](facebook/react#31526)) //<Sebastian Markbåge>// - **[5d89471ca6](facebook/react@5d89471ca6 )**: Export __COMPILER_RUNTIME in stable ([facebook#31540](facebook/react#31540)) //<lauren>// - **[3644f0bd21](facebook/react@3644f0bd21 )**: Use completedRenderEndTime as the start of the commit phase if it's an immediate commit ([facebook#31527](facebook/react#31527)) //<Sebastian Markbåge>// - **[8657869999](facebook/react@8657869999 )**: Separate Tracks for Components and Phases ([facebook#31525](facebook/react#31525)) //<Sebastian Markbåge>// - **[b15135b9f5](facebook/react@b15135b9f5 )**: [ez] Update useMemoCache return type ([facebook#31539](facebook/react#31539)) //<lauren>// Changelog: [General][Changed] - Bump React from 18.3.1 to 19.0.0 bypass-github-export-checks jest_e2e[run_all_tests] Reviewed By: cortinico Differential Revision: D67018480

Summary: X-link: facebook/react-native#48196 Pull Request resolved: #1400 - **[372ec00c03](facebook/react@372ec00c03 )**: Update ReactDebugInfo types to declare timing info separately ([#31714](facebook/react#31714)) //<Sebastian Markbåge>// - **[3d2ab01a55](facebook/react@3d2ab01a55 )**: [Flight] Extract special cases for Server Component return value position ([#31713](facebook/react#31713)) //<Sebastian Markbåge>// - **[1c9b138714](facebook/react@1c9b138714 )**: Don't serialize chunk ids for Hint and Console rows ([#31671](facebook/react#31671)) //<Sebastian Markbåge>// - **[de68d2f4a2](facebook/react@de68d2f4a2 )**: Register Suspense retry handlers in commit phase ([#31667](facebook/react#31667)) //<Josh Story>// - **[16d2bbbd1f](facebook/react@16d2bbbd1f )**: Client render dehydrated Suspense boundaries on document load ([#31620](facebook/react#31620)) //<Josh Story>// - **[5b0ef217ef](facebook/react@5b0ef217ef )**: s/server action/server function ([#31005](facebook/react#31005)) //<Ricky>// - **[e3b7ef32be](facebook/react@e3b7ef32be )**: [crud] Only export uRC when flag is enabled ([#31617](facebook/react#31617)) //<lauren>// - **[aba370f1e4](facebook/react@aba370f1e4 )**: Add moveBefore Experiment ([#31596](facebook/react#31596)) //<Sebastian Markbåge>// - **[1345c37941](facebook/react@1345c37941 )**: Mark all lanes in order on every new render ([#31615](facebook/react#31615)) //<Sebastian Markbåge>// - **[91061073d5](facebook/react@91061073d5 )**: Mark ping time as update ([#31611](facebook/react#31611)) //<Sebastian Markbåge>// - **[a9f14cb44e](facebook/react@a9f14cb44e )**: Fix Logging of Immediately Resolved Promises ([#31610](facebook/react#31610)) //<Sebastian Markbåge>// - **[c11c9510fa](facebook/react@c11c9510fa )**: [crud] Fix deps comparison bug ([#31599](facebook/react#31599)) //<lauren>// - **[64f89510af](facebook/react@64f89510af )**: [crud] Enable on RTR FB builds ([#31590](facebook/react#31590)) //<lauren>// - **[7558ffe84d](facebook/react@7558ffe84d )**: [crud] Fix copy paste typo ([#31588](facebook/react#31588)) //<lauren>// - **[7c254b6576](facebook/react@7c254b6576 )**: Log yielded time in the Component Track ([#31563](facebook/react#31563)) //<Sebastian Markbåge>// - **[6177b18c66](facebook/react@6177b18c66 )**: Track suspended time when the render doesn't commit because it suspended ([#31552](facebook/react#31552)) //<Sebastian Markbåge>// - **[eaf2d5c670](facebook/react@eaf2d5c670 )**: fix[eslint-plugin-react-hooks]: Fix error when callback argument is an identifier with an `as` expression ([#31119](facebook/react#31119)) //<Mark Skelton>// - **[047d95e85f](facebook/react@047d95e85f )**: [crud] Basic implementation ([#31523](facebook/react#31523)) //<lauren>// - **[92c0f5f85f](facebook/react@92c0f5f85f )**: Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel ([#31554](facebook/react#31554)) //<Sebastian Markbåge>// - **[053b3cb050](facebook/react@053b3cb050 )**: [crud] Rename Effect type ([#31557](facebook/react#31557)) //<lauren>// - **[7dd6b9e68a](facebook/react@7dd6b9e68a )**: [crud] Add enableUseResourceEffectHook flag ([#31556](facebook/react#31556)) //<lauren>// - **[d8afd1c82e](facebook/react@d8afd1c82e )**: [crud] Scaffold initial types ([#31555](facebook/react#31555)) //<lauren>// - **[3720870a97](facebook/react@3720870a97 )**: Log Render Phases that Never Committed ([#31548](facebook/react#31548)) //<Sebastian Markbåge>// - **[8a41d6ceab](facebook/react@8a41d6ceab )**: Unify RootDidNotComplete and RootSuspendedWithDelay exit path ([#31547](facebook/react#31547)) //<Sebastian Markbåge>// - **[63cde684f5](facebook/react@63cde684f5 )**: (chore): copy fix in <style> precedence error ([#31524](facebook/react#31524)) //<Zack Tanner>// - **[b01722d585](facebook/react@b01722d585 )**: Format event with "warning" yellow and prefix with "Event: " ([#31536](facebook/react#31536)) //<Sebastian Markbåge>// - **[c13986da78](facebook/react@c13986da78 )**: Fix Overlapping "message" Bug in Performance Track ([#31528](facebook/react#31528)) //<Sebastian Markbåge>// - **[4686872159](facebook/react@4686872159 )**: Log passive commit phase when it wasn't delayed ([#31526](facebook/react#31526)) //<Sebastian Markbåge>// - **[5d89471ca6](facebook/react@5d89471ca6 )**: Export __COMPILER_RUNTIME in stable ([#31540](facebook/react#31540)) //<lauren>// - **[3644f0bd21](facebook/react@3644f0bd21 )**: Use completedRenderEndTime as the start of the commit phase if it's an immediate commit ([#31527](facebook/react#31527)) //<Sebastian Markbåge>// - **[8657869999](facebook/react@8657869999 )**: Separate Tracks for Components and Phases ([#31525](facebook/react#31525)) //<Sebastian Markbåge>// - **[b15135b9f5](facebook/react@b15135b9f5 )**: [ez] Update useMemoCache return type ([#31539](facebook/react#31539)) //<lauren>// Changelog: [General][Changed] - Bump React from 18.3.1 to 19.0.0 bypass-github-export-checks jest_e2e[run_all_tests] Reviewed By: cortinico Differential Revision: D67018480 fbshipit-source-id: 39bca3261ffaa8bb7d74187510724d77cc36b196

Summary: Pull Request resolved: #48196 X-link: facebook/metro#1400 - **[372ec00c03](facebook/react@372ec00c03 )**: Update ReactDebugInfo types to declare timing info separately ([#31714](facebook/react#31714)) //<Sebastian Markbåge>// - **[3d2ab01a55](facebook/react@3d2ab01a55 )**: [Flight] Extract special cases for Server Component return value position ([#31713](facebook/react#31713)) //<Sebastian Markbåge>// - **[1c9b138714](facebook/react@1c9b138714 )**: Don't serialize chunk ids for Hint and Console rows ([#31671](facebook/react#31671)) //<Sebastian Markbåge>// - **[de68d2f4a2](facebook/react@de68d2f4a2 )**: Register Suspense retry handlers in commit phase ([#31667](facebook/react#31667)) //<Josh Story>// - **[16d2bbbd1f](facebook/react@16d2bbbd1f )**: Client render dehydrated Suspense boundaries on document load ([#31620](facebook/react#31620)) //<Josh Story>// - **[5b0ef217ef](facebook/react@5b0ef217ef )**: s/server action/server function ([#31005](facebook/react#31005)) //<Ricky>// - **[e3b7ef32be](facebook/react@e3b7ef32be )**: [crud] Only export uRC when flag is enabled ([#31617](facebook/react#31617)) //<lauren>// - **[aba370f1e4](facebook/react@aba370f1e4 )**: Add moveBefore Experiment ([#31596](facebook/react#31596)) //<Sebastian Markbåge>// - **[1345c37941](facebook/react@1345c37941 )**: Mark all lanes in order on every new render ([#31615](facebook/react#31615)) //<Sebastian Markbåge>// - **[91061073d5](facebook/react@91061073d5 )**: Mark ping time as update ([#31611](facebook/react#31611)) //<Sebastian Markbåge>// - **[a9f14cb44e](facebook/react@a9f14cb44e )**: Fix Logging of Immediately Resolved Promises ([#31610](facebook/react#31610)) //<Sebastian Markbåge>// - **[c11c9510fa](facebook/react@c11c9510fa )**: [crud] Fix deps comparison bug ([#31599](facebook/react#31599)) //<lauren>// - **[64f89510af](facebook/react@64f89510af )**: [crud] Enable on RTR FB builds ([#31590](facebook/react#31590)) //<lauren>// - **[7558ffe84d](facebook/react@7558ffe84d )**: [crud] Fix copy paste typo ([#31588](facebook/react#31588)) //<lauren>// - **[7c254b6576](facebook/react@7c254b6576 )**: Log yielded time in the Component Track ([#31563](facebook/react#31563)) //<Sebastian Markbåge>// - **[6177b18c66](facebook/react@6177b18c66 )**: Track suspended time when the render doesn't commit because it suspended ([#31552](facebook/react#31552)) //<Sebastian Markbåge>// - **[eaf2d5c670](facebook/react@eaf2d5c670 )**: fix[eslint-plugin-react-hooks]: Fix error when callback argument is an identifier with an `as` expression ([#31119](facebook/react#31119)) //<Mark Skelton>// - **[047d95e85f](facebook/react@047d95e85f )**: [crud] Basic implementation ([#31523](facebook/react#31523)) //<lauren>// - **[92c0f5f85f](facebook/react@92c0f5f85f )**: Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel ([#31554](facebook/react#31554)) //<Sebastian Markbåge>// - **[053b3cb050](facebook/react@053b3cb050 )**: [crud] Rename Effect type ([#31557](facebook/react#31557)) //<lauren>// - **[7dd6b9e68a](facebook/react@7dd6b9e68a )**: [crud] Add enableUseResourceEffectHook flag ([#31556](facebook/react#31556)) //<lauren>// - **[d8afd1c82e](facebook/react@d8afd1c82e )**: [crud] Scaffold initial types ([#31555](facebook/react#31555)) //<lauren>// - **[3720870a97](facebook/react@3720870a97 )**: Log Render Phases that Never Committed ([#31548](facebook/react#31548)) //<Sebastian Markbåge>// - **[8a41d6ceab](facebook/react@8a41d6ceab )**: Unify RootDidNotComplete and RootSuspendedWithDelay exit path ([#31547](facebook/react#31547)) //<Sebastian Markbåge>// - **[63cde684f5](facebook/react@63cde684f5 )**: (chore): copy fix in <style> precedence error ([#31524](facebook/react#31524)) //<Zack Tanner>// - **[b01722d585](facebook/react@b01722d585 )**: Format event with "warning" yellow and prefix with "Event: " ([#31536](facebook/react#31536)) //<Sebastian Markbåge>// - **[c13986da78](facebook/react@c13986da78 )**: Fix Overlapping "message" Bug in Performance Track ([#31528](facebook/react#31528)) //<Sebastian Markbåge>// - **[4686872159](facebook/react@4686872159 )**: Log passive commit phase when it wasn't delayed ([#31526](facebook/react#31526)) //<Sebastian Markbåge>// - **[5d89471ca6](facebook/react@5d89471ca6 )**: Export __COMPILER_RUNTIME in stable ([#31540](facebook/react#31540)) //<lauren>// - **[3644f0bd21](facebook/react@3644f0bd21 )**: Use completedRenderEndTime as the start of the commit phase if it's an immediate commit ([#31527](facebook/react#31527)) //<Sebastian Markbåge>// - **[8657869999](facebook/react@8657869999 )**: Separate Tracks for Components and Phases ([#31525](facebook/react#31525)) //<Sebastian Markbåge>// - **[b15135b9f5](facebook/react@b15135b9f5 )**: [ez] Update useMemoCache return type ([#31539](facebook/react#31539)) //<lauren>// Changelog: [General][Changed] - Bump React from 18.3.1 to 19.0.0 bypass-github-export-checks jest_e2e[run_all_tests] Reviewed By: cortinico Differential Revision: D67018480 fbshipit-source-id: 39bca3261ffaa8bb7d74187510724d77cc36b196

Track separate SuspendedOnAction flag by rethrowing a separate Suspen…

404fb64

…seActionException sentinel This lets us track separately if something was suspended on an Action using useActionState.

sebmarkbage requested a review from acdlite November 15, 2024 20:40

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 15, 2024

sebmarkbage commented Nov 15, 2024

View reviewed changes

vercel bot deployed to Preview November 15, 2024 20:43 View deployment

acdlite approved these changes Nov 15, 2024

View reviewed changes

sebmarkbage merged commit 92c0f5f into facebook:main Nov 15, 2024
184 checks passed

vercel-release-bot mentioned this pull request Nov 20, 2024

Upgrade React from 380f5d67-20241113 to 64f89510-20241119 vercel/next.js#73011

Closed

This was referenced Dec 4, 2024

Upgrade React from b01722d5-20241114 to 1b1283ad-20241203 vercel/next.js#73506

Merged

Upgrade React from b01722d5-20241114 to de68d2f4-20241204 vercel/next.js#73522

Closed

cipolleschi mentioned this pull request Dec 10, 2024

React Native sync for revisions de68d2f...372ec00 facebook/react-native#48196

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel #31554

Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel #31554

sebmarkbage commented Nov 15, 2024 •

edited

Loading

vercel bot commented Nov 15, 2024 •

edited

Loading

sebmarkbage Nov 15, 2024

acdlite Nov 15, 2024

react-sizebot commented Nov 15, 2024

Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel #31554

Track separate SuspendedOnAction flag by rethrowing a separate SuspenseActionException sentinel #31554

Conversation

sebmarkbage commented Nov 15, 2024 • edited Loading

vercel bot commented Nov 15, 2024 • edited Loading

sebmarkbage Nov 15, 2024

Choose a reason for hiding this comment

acdlite Nov 15, 2024

Choose a reason for hiding this comment

react-sizebot commented Nov 15, 2024

Critical size changes

Significant size changes

sebmarkbage commented Nov 15, 2024 •

edited

Loading

vercel bot commented Nov 15, 2024 •

edited

Loading