From 822bde8bad54fd8216b9f3a69e83b223c1a10259 Mon Sep 17 00:00:00 2001 From: XiaoPi <530257315@qq.com> Date: Mon, 3 Jun 2024 10:36:47 +0800 Subject: [PATCH 1/2] fix: only call readTestFilter if the filter option is enabled --- compiler/packages/snap/src/runner-watch.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compiler/packages/snap/src/runner-watch.ts b/compiler/packages/snap/src/runner-watch.ts index 6a229f5155d92..5ae331c071f06 100644 --- a/compiler/packages/snap/src/runner-watch.ts +++ b/compiler/packages/snap/src/runner-watch.ts @@ -153,8 +153,8 @@ function subscribeFilterFile( } else if ( events.findIndex((event) => event.path.includes(FILTER_FILENAME)) !== -1 ) { - state.filter = await readTestFilter(); if (state.mode.filter) { + state.filter = await readTestFilter(); state.mode.action = RunnerAction.Test; onChange(state); } @@ -218,7 +218,7 @@ export async function makeWatchRunner( action: RunnerAction.Test, filter: filterMode, }, - filter: await readTestFilter(), + filter: filterMode? await readTestFilter(): null, }; subscribeTsc(state, onChange); From 3194be688322f47d576edaaff10ab3df863caf51 Mon Sep 17 00:00:00 2001 From: XiaoPi <530257315@qq.com> Date: Mon, 3 Jun 2024 13:42:32 +0800 Subject: [PATCH 2/2] prettier --- compiler/packages/snap/src/runner-watch.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler/packages/snap/src/runner-watch.ts b/compiler/packages/snap/src/runner-watch.ts index 5ae331c071f06..bebedef721600 100644 --- a/compiler/packages/snap/src/runner-watch.ts +++ b/compiler/packages/snap/src/runner-watch.ts @@ -218,7 +218,7 @@ export async function makeWatchRunner( action: RunnerAction.Test, filter: filterMode, }, - filter: filterMode? await readTestFilter(): null, + filter: filterMode ? await readTestFilter() : null, }; subscribeTsc(state, onChange);