compiler: fix jsx text attributes with double quotes #29079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
josephsavona
force-pushed
the
fix-jsx-text-attribute-w-double-quote
branch
from
ff04156 to
3f0461e
Compare
gsathya
approved these changes
May 15, 2024
|
Comparing: c93c30f...9e82704 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
josephsavona
force-pushed
the
fix-jsx-text-attribute-w-double-quote
branch
from
3f0461e to
9e82704
Compare
mofeiZ
approved these changes
May 15, 2024
There was a problem hiding this comment.
Ahh makes sense, this should be a no-op to jsx transforms that consume compiler output and make tools like playground easier to use.
Seems spec compatible as well as the spec doesn't define escaped characters (looking at esbuild facing the same problem here evanw/esbuild#959)
mofeiZ
added a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29069 by detecting the presence of double-quotes in JSX attribute strings and falling back to using an expression container.