From c690fdc73d6fbf744e4faa5e5d6c1b3aa6708cb0 Mon Sep 17 00:00:00 2001
From: Biki-das <bikid475@gmail.com>
Date: Tue, 5 Dec 2023 21:55:01 +0530
Subject: [PATCH 1/2] added tests for more coverage in reactDom-input and
 reactText-area

---
 .../src/__tests__/ReactDOMInput-test.js       | 15 +++-
 .../src/__tests__/ReactDOMTextarea-test.js    | 81 +++++++++++++++++++
 2 files changed, 93 insertions(+), 3 deletions(-)

diff --git a/packages/react-dom/src/__tests__/ReactDOMInput-test.js b/packages/react-dom/src/__tests__/ReactDOMInput-test.js
index be4b59ce0806e..6b8baaddbe023 100644
--- a/packages/react-dom/src/__tests__/ReactDOMInput-test.js
+++ b/packages/react-dom/src/__tests__/ReactDOMInput-test.js
@@ -110,7 +110,10 @@ describe('ReactDOMInput', () => {
     expect(() => {
       ReactDOM.render(<input type="text" value={0} />, container);
     }).toErrorDev(
-      'Warning: You provided a `value` prop to a form field without an `onChange` handler.',
+      'Warning: You provided a `value` prop to a form ' +
+        'field without an `onChange` handler. This will render a read-only ' +
+        'field. If the field should be mutable use `defaultValue`. ' +
+        'Otherwise, set either `onChange` or `readOnly`.',
     );
   });
 
@@ -118,7 +121,10 @@ describe('ReactDOMInput', () => {
     expect(() => {
       ReactDOM.render(<input type="text" value="" />, container);
     }).toErrorDev(
-      'Warning: You provided a `value` prop to a form field without an `onChange` handler.',
+      'Warning: You provided a `value` prop to a form ' +
+        'field without an `onChange` handler. This will render a read-only ' +
+        'field. If the field should be mutable use `defaultValue`. ' +
+        'Otherwise, set either `onChange` or `readOnly`.',
     );
   });
 
@@ -126,7 +132,10 @@ describe('ReactDOMInput', () => {
     expect(() => {
       ReactDOM.render(<input type="text" value="0" />, container);
     }).toErrorDev(
-      'Warning: You provided a `value` prop to a form field without an `onChange` handler.',
+      'Warning: You provided a `value` prop to a form ' +
+        'field without an `onChange` handler. This will render a read-only ' +
+        'field. If the field should be mutable use `defaultValue`. ' +
+        'Otherwise, set either `onChange` or `readOnly`.',
     );
   });
 
diff --git a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
index 39a1bac1e9ede..5ed6557f9878f 100644
--- a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
+++ b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
@@ -759,4 +759,85 @@ describe('ReactDOMTextarea', () => {
     ReactDOM.render(<textarea defaultValue={null} />, container);
     expect(node.defaultValue).toBe('');
   });
+
+  it('should not warn about missing onChange if value is not set', () => {
+    expect(() => {
+      ReactTestUtils.renderIntoDocument(<textarea />);
+    }).not.toThrow();
+  });
+
+  it('should not warn about missing onChange if value is undefined', () => {
+    expect(() => {
+      ReactTestUtils.renderIntoDocument(<textarea value={undefined} />);
+    }).not.toThrow();
+  });
+
+  it('should not warn about missing onChange if onChange is set', () => {
+    expect(() => {
+      const change = jest.fn();
+      ReactTestUtils.renderIntoDocument(
+        <textarea value="something" onChange={change} />,
+      );
+    }).not.toThrow();
+  });
+
+  it('should not warn about missing onChange if disabled is true', () => {
+    expect(() => {
+      ReactTestUtils.renderIntoDocument(
+        <textarea value="something" disabled={true} />,
+      );
+    }).not.toThrow();
+  });
+
+  it('should not warn about missing onChange if value is not set', () => {
+    expect(() => {
+      ReactTestUtils.renderIntoDocument(
+        <textarea value="something" readOnly={true} />,
+      );
+    }).not.toThrow();
+  });
+
+  it('should warn about missing onChange if value is false', () => {
+    expect(() =>
+      ReactTestUtils.renderIntoDocument(<textarea value={false} />),
+    ).toErrorDev(
+      'Warning: You provided a `value` prop to a form ' +
+      'field without an `onChange` handler. This will render a read-only ' +
+      'field. If the field should be mutable use `defaultValue`. ' +
+      'Otherwise, set either `onChange` or `readOnly`.',
+    );
+  });
+
+  it('should warn about missing onChange if value is 0', () => {
+    expect(() =>
+      ReactTestUtils.renderIntoDocument(<textarea value={0} />),
+    ).toErrorDev(
+      'Warning: You provided a `value` prop to a form ' +
+      'field without an `onChange` handler. This will render a read-only ' +
+      'field. If the field should be mutable use `defaultValue`. ' +
+      'Otherwise, set either `onChange` or `readOnly`.',
+    );
+  });
+
+  it('should warn about missing onChange if value is "0"', () => {
+    expect(() =>
+      ReactTestUtils.renderIntoDocument(<textarea value="0" />),
+    ).toErrorDev(
+      'Warning: You provided a `value` prop to a form ' +
+      'field without an `onChange` handler. This will render a read-only ' +
+      'field. If the field should be mutable use `defaultValue`. ' +
+      'Otherwise, set either `onChange` or `readOnly`.',
+    );
+  });
+
+  it('should warn about missing onChange if value is ""', () => {
+    expect(() =>
+      ReactTestUtils.renderIntoDocument(<textarea value="" />),
+    ).toErrorDev(
+      'Warning: You provided a `value` prop to a form ' +
+      'field without an `onChange` handler. This will render a read-only ' +
+      'field. If the field should be mutable use `defaultValue`. ' +
+      'Otherwise, set either `onChange` or `readOnly`.',
+    );
+  });
 });

From d795958b8f55bd2f9c4c1e0f1e96819111ae9cba Mon Sep 17 00:00:00 2001
From: Biki-das <bikid475@gmail.com>
Date: Tue, 5 Dec 2023 22:05:50 +0530
Subject: [PATCH 2/2] lint fix

---
 .../src/__tests__/ReactDOMTextarea-test.js    | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
index 5ed6557f9878f..810452c64a313 100644
--- a/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
+++ b/packages/react-dom/src/__tests__/ReactDOMTextarea-test.js
@@ -802,9 +802,9 @@ describe('ReactDOMTextarea', () => {
       ReactTestUtils.renderIntoDocument(<textarea value={false} />),
     ).toErrorDev(
       'Warning: You provided a `value` prop to a form ' +
-      'field without an `onChange` handler. This will render a read-only ' +
-      'field. If the field should be mutable use `defaultValue`. ' +
-      'Otherwise, set either `onChange` or `readOnly`.',
+        'field without an `onChange` handler. This will render a read-only ' +
+        'field. If the field should be mutable use `defaultValue`. ' +
+        'Otherwise, set either `onChange` or `readOnly`.',
     );
   });
 
@@ -813,9 +813,9 @@ describe('ReactDOMTextarea', () => {
       ReactTestUtils.renderIntoDocument(<textarea value={0} />),
     ).toErrorDev(
       'Warning: You provided a `value` prop to a form ' +
-      'field without an `onChange` handler. This will render a read-only ' +
-      'field. If the field should be mutable use `defaultValue`. ' +
-      'Otherwise, set either `onChange` or `readOnly`.',
+        'field without an `onChange` handler. This will render a read-only ' +
+        'field. If the field should be mutable use `defaultValue`. ' +
+        'Otherwise, set either `onChange` or `readOnly`.',
     );
   });
 
@@ -824,9 +824,9 @@ describe('ReactDOMTextarea', () => {
       ReactTestUtils.renderIntoDocument(<textarea value="0" />),
     ).toErrorDev(
       'Warning: You provided a `value` prop to a form ' +
-      'field without an `onChange` handler. This will render a read-only ' +
-      'field. If the field should be mutable use `defaultValue`. ' +
-      'Otherwise, set either `onChange` or `readOnly`.',
+        'field without an `onChange` handler. This will render a read-only ' +
+        'field. If the field should be mutable use `defaultValue`. ' +
+        'Otherwise, set either `onChange` or `readOnly`.',
     );
   });
 
@@ -835,9 +835,9 @@ describe('ReactDOMTextarea', () => {
       ReactTestUtils.renderIntoDocument(<textarea value="" />),
     ).toErrorDev(
       'Warning: You provided a `value` prop to a form ' +
-      'field without an `onChange` handler. This will render a read-only ' +
-      'field. If the field should be mutable use `defaultValue`. ' +
-      'Otherwise, set either `onChange` or `readOnly`.',
+        'field without an `onChange` handler. This will render a read-only ' +
+        'field. If the field should be mutable use `defaultValue`. ' +
+        'Otherwise, set either `onChange` or `readOnly`.',
     );
   });
 });